BroadcomMFD / cobol-control-flow

COBOL Control Flow is an extension for Visual Studio Code that provides graphical visualization of program flow for programs written in COBOL.
https://marketplace.visualstudio.com/items?itemName=broadcomMFD.ccf
Other
9 stars 8 forks source link

Compiler directives in source ==> various problems #24

Closed FALLAI-Denis closed 2 years ago

FALLAI-Denis commented 3 years ago

In the presence of compilation directives in the source code, the Cobol Control Flow extension triggers various anomalies.

20210620-CCF04

20210620-CCF05

20210620-CCF06

zimlu02 commented 2 years ago

Hi Denis, could you please confirm whether the latest 0.4.1 release fixes your issue? Thank you.

FALLAI-Denis commented 2 years ago

Hi @zimlu02

image

We do not use Broadcom's "COBOL Language Support" extension, but that of another vendor.

zimlu02 commented 2 years ago

That is still OK, you don't necessarily have to use COBOL LS. This message only indicates that the file contains too many syntactic errors, that CCF parser cannot build a meaningful graph. The syntax awareness tool such as COBOL LS or others may just help you to identify syntax problems in the code...

FALLAI-Denis commented 2 years ago

Hi,

The problem is still present in version 0.4.1. Only the error message differs:

image

Without compilation directives in source code, the graph is displayed correctly.

I found a app.log in installation folder of extension:

3/4/2022, 8:14:20 AM TypeError: Cannot read property 'type' of undefined

FALLAI-Denis commented 2 years ago

Hi,

For information, version 1.0.2 of CCF seems to have fixed some problems that we encountered with the structure of our COBOL code.

Now the graph is displayed correctly and corresponds to the structure of our program. Moreover, CCF works with another COBOL code editor extension than "COBOL Language Support", which is a real satisfaction for us.

Thanks to the CCF teams for the work done.

We still have to validate the operation of CCF on other use cases, and if all goes well, CCF will become one of the major bricks of our new COBOL Development Workshop.

image

image

image

zimlu02 commented 2 years ago

Hi Denis,

we are very happy this version works for you! Can I close this issue? Please if needed open new issues for your other use cases. Thank you.

FALLAI-Denis commented 2 years ago

Yes !