search

BroadcomMFD / cobol-control-flow

COBOL Control Flow is an extension for Visual Studio Code that provides graphical visualization of program flow for programs written in COBOL.
https://marketplace.visualstudio.com/items?itemName=broadcomMFD.ccf
Other
9 stars 8 forks source link

A procedure was not detected #5

Closed jellypuno closed 2 years ago

jellypuno commented 4 years ago

The WRITE-HEADERS is not part of the initial procedures connected to PROCEDURE DIVISION.

The correct flow should be:

  1. OPEN FILES
  2. WRITE HEADERS
  3. READ NEXT RECORD A. READ RECORD B. WRITE RECORD i. WRITE HEADERS (If Report Page Break)
  4. WRITE TRAILERS
  5. CLOSE STOP

image

jellypuno commented 4 years ago

Additional issues on procedures

  1. EXIT PARAGRAPH was considered a separate procedure
  2. The variables after the EXIT PARAGRAPH was considered a procedure as well

image

Nurkambay commented 2 years ago

This bug should be split into 2 parts at least. Also, before building a graph you must resolve all errors first. Otherwise, no guarantee that graph will be relevant :-)

jellypuno commented 2 years ago

@Nurkambay I fixed the errors but it is still the same. This time the init and write paragraphs are not included in the graph.

image

Nurkambay commented 2 years ago

@jellypuno yep, that's why it is a bug. It is fixed now. Another issue is that If you have a significant error in the COBOL code you will not see anything relevant to the real CCF graph :-( And it is another issue that must be fixed on the COBOL LS side

zimlu02 commented 2 years ago

Fixed in the 1.0.1 release. https://github.com/BroadcomMFD/cobol-control-flow/releases/tag/v1.0.1