search

BroadcomMFD / doggos-gse

1 stars 3 forks source link

Add pugs breed support into the doggos app #3

Open nickImbirev opened 2 years ago

nickImbirev commented 2 years ago

As a DOGGOS application user, I would like to see the dog breed 'PUG' in the output report of the application.

INPUT:

Screenshot 2022-05-11 at 16 51 14

AS IS: OUTPUT:

Screenshot 2022-05-11 at 16 49 14

TO BE: OUTPUT:

Screenshot 2022-05-11 at 16 51 46
nickImbirev commented 2 years ago

Technical scenario to complete the feature request:

Please, assign this issue to you, once you start working on it, so everybody can see it.

  1. Open the installed repository and create a Git branch for the enhancement (suggested branch name: add-pugs-support).
  2. Take a look into the program source code according to the guide.
  3. Update the source code module DOGGOS.cbl.
    • Register a new dog breed in the BREED-INDEXES structure (follow the existing breeds for the examples). Please, do not forget to update the breed index value.
    • Add a new use case into the UPDATE-ACCUMULATOR section (follow the existing breeds for the examples).
    • Add a snippet to write the new dog breed results into the output after the line 97 (follow the existing breeds for the examples). Note: Do not hesitate to use COBOL Control flow and COBOL LSP VSCode extensions for this change.
  4. Build the source code according to the guide.
  5. Update the test input file according to the requirements using the guide.
  6. Run the manual test with the code using the guide.
  7. (Optional): If you have issues with the understanding, why the changes are not working properly - please, debug the application using the guide.
  8. (Optional): If you feel confident about the changes, please, run the regression automated tests suite according to the guide and update the test cases with your changes.

After you did the change, please, make a git commit and push your changes into the remote repository, open a Pull Request into the main branch with your changes and ask for the code review.

nickImbirev commented 2 years ago

Traditional scenario

Technical scenario to complete the feature request:

Please, assign this issue to you, once you start working on it, so everybody can see it.

  1. Connect to the Endevor ISPF panel using the guide.
  2. Update the source code element DOGGOS of the COBOL type using the guide.
    • Register a new dog breed in the BREED-INDEXES structure (follow the existing breeds for the examples). Please, do not forget to update the breed index value.
    • Add a new use case into the UPDATE-ACCUMULATOR section (follow the existing breeds for the examples).
    • Add a snippet to write the new dog breed results into the output after the line 97 (follow the existing breeds for the examples).
  3. Build the source code according to the guide.
  4. Update the test input file according to the requirements using the guide.
  5. Run the manual test with the code using the guide.