BroadcomMFD / rexx-language-support

The Rexx Language Support plugin leverages the language server protocol to provide syntax awareness, syntax coloring and autocomplete features for Rexx code.
https://marketplace.visualstudio.com/items?itemName=broadcomMFD.lsp-for-rexx
Other
4 stars 5 forks source link

Autocomplete not working after upgrading to 0.0.15 #4

Open ClaudeBirtz opened 4 years ago

ClaudeBirtz commented 4 years ago

Hi,

thanks for your helpful extension. Unfortunately autocomplete and problem detection stopped working a few weeks ago, I suspected I had somehow messed up my settings. Trying to find the source of the error, I noticed that when I switch back to version 0.0.12 autocomplete and problem detection work again.

0.0.14 has the same behaviour than 0.0.15.

Best regards, Claude

ishche commented 4 years ago

Thank you! What version of Java do you have?

ClaudeBirtz commented 4 years ago

Hi,

when I enter java -version in a command prompt:

openjdk version "1.8.0_232" OpenJDK Runtime Environment Corretto-8.232.09.1 (build 1.8.0_232-b09) OpenJDK 64-Bit Server VM Corretto-8.232.09.1 (build 25.232-b09, mixed mode)

ishche commented 4 years ago

openjdk version "1.8.0_232"

Formally we don't support Java 8 anymore. But I don't see a reason why it shouldn't work with it. I'll check if where Is something wrong with 0.0.15.

You can try to update java to see if it fixes the problem.

ClaudeBirtz commented 4 years ago

Thank you very much for your help,

I've updated to Java 11 and I noticed that in a new, empty file the auto completion works fine, but gets slower as the file gets bigger to the point it seems it doesn't work at all. I also see a big increase in CPU usage in taskmanager during that time.

Dropping back to 0.0.12 solves this issue, even in large files.

I also don't have these "abc" suggestions in REXX codes, whereas they appear when I use Broadcom JCL extension, or any other extension. I guess that's not normal either, maybe I should try to reinstall VS Code?

ishche commented 4 years ago

There is no need to reinstall the vscode. But I want to ask you to disable all other vscode extensions and check if the issue with "abc" and performance is still there.

How big that file when it's almost not working?

ClaudeBirtz commented 4 years ago

I disabled all extensions, first only in the workspace, then globally. Performance is fine for a small file with a few instructions, but the "abc" suggestions newer show up. If I disable REXX extension as well, the "abc" suggestions show. The "large" file I was talking about has 400 lines. I'm quite sure none of this was an issue when I first started using the extension, but as I did hardly any work in REXX other than editing a few lines in the recent months, I can't say for sure.

ishche commented 4 years ago

Thanks a lot. 400 lines it's not a big file and REXX extension definitely should work with it. I'll create separate issues for them: Performance: https://github.com/BroadcomMFD/rexx-language-support/issues/5 "abc" suggestions: https://github.com/BroadcomMFD/rexx-language-support/issues/6

geraldpf commented 4 years ago

Hi Claude,

hope you are well my friend. If you need any information or presentation around Brightside/Zowe/Visual Studio Code, please let me know. As you know, this is my area and I'm happy to help wherever I can.

Kind Regards, Gerald

Am Mo., 5. Okt. 2020 um 08:49 Uhr schrieb ClaudeBirtz < notifications@github.com>:

Hi,

thanks for your helpful extension. Unfortunately autocomplete and problem detection stopped working a few weeks ago, I suspected I had somehow messed up my settings. Trying to find the source of the error, I noticed that when I switch back to version 0.0.12 autocomplete and problem detection work again.

0.0.14 has the same behaviour than 0.0.15.

Best regards, Claude

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BroadcomMFD/rexx-language-support/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALFAHUD52M3STBWGOVYXQQDSJFT5XANCNFSM4SEJA6FA .

--

Gerald Pfeiffer

Technical Consulting | Mainframe Division Broadcom

CA Deutschland GmbH | Marienburgstraße 35 | 64297 Darmstadt mobile: +49 170 853 852 0 gerald.pfeiffer@broadcom.com | broadcom.com

HRB Darmstadt 1706 | Geschäftsführer: Holger Stickl, Deborah Streeter

ishche commented 3 years ago

I was able to identify the performance problem. It will take some time to resolve it. But I made some performance tweaks for now. There are available in 0.0.17 on the marketplace.