search

BroadleafCommerce / ReactStarter

Broadleaf Commerce Spring Boot React Starter
Creative Commons Zero v1.0 Universal
43 stars 41 forks source link

Bump elliptic from 6.4.0 to 6.5.3 in /site #28

Closed dependabot[bot] closed 4 years ago

dependabot[bot] commented 4 years ago

Bumps elliptic from 6.4.0 to 6.5.3.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/BroadleafCommerce/ReactStarter/network/alerts).
cja769 commented 4 years ago

@ncrum Are changes like these suppose to made against the yarn.lock file? If this change is fine, and you can remember what this dependency is used for, can you explain what it's for so that @riteshadhikari17 or I can test it?

ncrum commented 4 years ago

I typically will update the dependency in package.json if it is a first-class dependency we include. That way my package.json is up to date with the latest versions of the libraries we depend on. In this case, this is a dependency of a dependency (not sure what includes it though). I usually end up figuring out which dependency I have that includes this library, and upgrade that instead. I use yarn why elliptic to figure that out.

If there is no viable release for the dependent, then I suppose directly updating the yarn.lock as done here could be sufficient. Of course, if the dependent has a fixed version range for this library, e.g. it must be less than 6.5 for some reason, then that could be a problem.

I'm not sure how you would test it. If you find out it is for a certain library, we could test the code that uses that library. Sometimes though, these warnings are for dev tooling, or we might not even use the code ourselves at all, and so there isn't really anything to test.

cja769 commented 4 years ago

In that case I suppose it's just a case of whether we should just merge it or not. What's your thoughts on that?

ncrum commented 4 years ago

I don't see any problems with merging it. If it was targeting one of our direct dependents, might warrant a further look.