Broham / suncalcPy

A python implementation of the SunCalc javascript library.
MIT License
41 stars 18 forks source link

Development status? #10

Open robinpaulson opened 2 years ago

robinpaulson commented 2 years ago

Hi, this library is perfect for a project I have in mind, it's lightweight and small.

However, there are a few open issues and pull requests, plus a variety of other minor problems I've seen. What do you think about fixing them up? If not, I am prepared to fork and continue development with the assistance of other coders.

Thanks

robinpaulson commented 2 years ago

@alihakimtaskiran and @barrald and @MrHarcombe It's been a while since the owner of the code has made any changes, so I'm going to fork and continue development. I'd like to include your pull requests, they fix a few important bugs.

https://github.com/robinpaulson/suncalcPy

MrHarcombe commented 2 years ago

Fine by me 👍


Ian Harcombe

On Thu, 28 Oct 2021, 23:18 robinpaulson, @.***> wrote:

@alihakimtaskiran https://github.com/alihakimtaskiran and @barrald https://github.com/barrald and @MrHarcombe https://github.com/MrHarcombe It's been a while since the owner of the code has made any changes, so I'm going to fork and continue development. I'd like to include your pull requests, they fix a few important bugs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Broham/suncalcPy/issues/10#issuecomment-954267949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQU6A5OUL3HDHLZWDHKN7DUJHD4NANCNFSM5GHTVVKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alihakimtaskiran commented 2 years ago

Hi @robinpaulson , I have fixed these bugs and made it object based in Martan Solar Power Plant when there was no response from @Broham . If you wish you can join Martian Solar Power Plant . We can continue to develop it and make it compatible with all planets not just Earth. Best Regards,

@alihakimtaskiran and @barrald and @MrHarcombe It's been a while since the owner of the code has made any changes, so I'm going to fork and continue development. I'd like to include your pull requests, they fix a few important bugs.

https://github.com/robinpaulson/suncalcPy

robinpaulson commented 2 years ago

Hi @alihakimtaskiran thanks for getting back to me, that sounds like a really interesting project! However, i want to keep the code as small as possible, i intend to run it on a device with very limited storage (a raspberry pi pico), so expanding for other celestial objects, while interesting would cause me problems and distract me from the thing I want to do with it.

I will keep an eye on what you're doing though, perhaps there are some commits I can pull to my fork.

Cheers!

MrHarcombe commented 2 years ago

I would just point out that the author has, in the last hour, merged my pull request; so they may be in the process of tidying up ready to update (or readying to close down and handover - who knows). Either way, there was recent activity... watch this space?

robinpaulson commented 2 years ago

Thanks for the heads up @MrHarcombe ; I'll keep track of what the owner does and see how it fits with my fork.