Broke-Brokers / Broke_BRokers-soen341projectF2023

This is the github for everything about the SOEN341 real estate project of the Broke Brokers team
0 stars 0 forks source link

TASK 0.8 - Clean components #321

Open isaisa002 opened 9 months ago

isaisa002 commented 9 months ago

from : #298

BRANCH #322 & #323

TASK DESCRIPTION

As a developper, I want to allow components to read snapshot so that functionalities works with snapshot of Firebase .

Issue: Search for broker filter doesn't works with snapshot while broker card is

In profile page, broker and property result grid isn't link to new database

In search property page, property result grid isn't link to new database

isaisa002 commented 9 months ago

Resolve filter for search for broker

image

image

isaisa002 commented 9 months ago

Resolve broker result grid of profile page

Components used : BrokerCard & Admin Broker Grid

image

image

Result

image

isaisa002 commented 9 months ago

Resolve property result grid of profile page

Components changed: Creation Property & House Card

Previously

Now

Result with current Firebase with 3 properties

image

isaisa002 commented 9 months ago

Resolve property result grid search property page

Similarly to the property result grid of profile page

Components changed/used : Card home, House Card

image

image

Result

Currently have 2 filter : first one from the Search_Filter component

: second one implemented in Card home and works with Card home.csss

image

update: removed edit & delete button for property card of search property ( home card // house card is property card of profile broker)

DominiqueProulx commented 9 months ago

Thanks Isabelle! Unfortunately They said that nothing after the 26 will be taken into account for the grading :( but at least it will work for the demo!! Thanks!!

isaisa002 commented 9 months ago

Thanks Isabelle! Unfortunately They said that nothing after the 26 will be taken into account for the grading :( but at least it will work for the demo!! Thanks!!

No worries! Could you verify if it's can be merged?

DominiqueProulx commented 9 months ago

Thanks Isabelle! Unfortunately They said that nothing after the 26 will be taken into account for the grading :( but at least it will work for the demo!! Thanks!!

No worries! Could you verify if it's can be merged?

i'll look at it right now

DominiqueProulx commented 9 months ago

I left some comments in your pull request https://github.com/Broke-Brokers/Broke_BRokers-soen341projectF2023/pull/322

The unit tests are fixed and the tests are running right now. I'll review and accept merge once the CI test is clear. sonarCloud test will fail but it's expected, as no test coverage was added