search

BrontosaurusTails / Sovereign

MIT License
0 stars 1 forks source link

add basic eslint rules #16

Closed yeibercano closed 7 years ago

yeibercano commented 7 years ago

I went ahead of this. Let me know if it makes sense or if we rather use something else.

richHong commented 7 years ago

@yeibercano I thought we were going with prettify instead of ESLint?

Otherwise it LGTM 👍

yeibercano commented 7 years ago

@richHong, yeah. I jumped the gun and made the PR before we had talked. However, Prettier does not replace ESLINT. Prettier doesn't not check code quality:

Code-quality rules: eg no-unused-vars, no-extra-bind, no-implicit-globals, prefer-promise-reject-errors...

I have made some changes to the PR using prettier with ESLINT. Alternatively, we can have both separated. However, it seems we should use ESLINT or any other code quality linter whether or not we use Prettier.

This is the firs time I have used them both together. @colinlmcdonald , what do you think? I am happy to either separate them. And maybe you can set up Prettier and I do ESLINT (Code-quality) ? Also, we can just wait on this PR :)

yeibercano commented 7 years ago

Also, here is how Prettier is using eslint

By the way, Prettier is using PostCSS ;)