Bronya-Rand / DDLCModTemplate2.0

A new template for producing DDLC mods that adhere to Team Salvato's guidelines based off DDLC itself.
58 stars 18 forks source link

Auto Color Feat Adjustments #19

Closed Amalrix closed 2 years ago

Amalrix commented 2 years ago

This PR does the following:

Bronya-Rand commented 2 years ago

For this PR I have a bit of issues.

Logo - I feel this might complicate things for newcomers on making a logo, especially with the foreground Doki Doki text. I think this should just be normal with the option to do so being a comment. Code Pt 1 (Screens) - I rather keep the recolor code commented unless the user wants to use it and default still to the traditional Ren'Py/DDLC code as options for the users to choose (similar to how I did it with the text outline even though I know it is defaulted on most things) Code Pt 2 - I don't think the check is necessary. TBH this could just be done by making blackCol and whiteCol be filled in to use as like the original code.

Amalrix commented 2 years ago

For this PR I have a bit of issues.

Logo - I feel this might complicate things for newcomers on making a logo, especially with the foreground Doki Doki text. I think this should just be normal with the option to do so being a comment. Code Pt 1 (Screens) - I rather keep the recolor code commented unless the user wants to use it and default still to the traditional Ren'Py/DDLC code as options for the users to choose (similar to how I did it with the text outline even though I know it is defaulted on most things) Code Pt 2 - I don't think the check is necessary. TBH this could just be done by making blackCol and whiteCol be filled in to use as like the original code.

I see your concerns about this PR, but I guess I should explain my thought process behind it: Basically, the idea was to make the commenting out obselete by adding the check and making usage of the auto color feature easier. The check is technically not necessary anyways, which is true, but the point of it was - since the lines would no longer be commented out - to ensure the 'quality' of the assets (since the recolorization process does lower it), if the user decides to not change the default values. I thought this might make the whole thing a bit simpler by having less lines and the auto color feature ready-to-use, but for a total begginer I can see how it might actually be rather confusing. By adding the comments back, the check is truly obsolete (as it builts on the premise that it's not commented out), so it could be removed. Regarding the logo: When commenting out the lines again, it would only make sense to comment this out like you said, since it's mostly/only important for the whole recolorization process.

I will make a commit to the branch shortly, which will address your feedback.