Bronya-Rand / DDLCModTemplate2.0

A new template for producing DDLC mods that adhere to Team Salvato's guidelines based off DDLC itself.
58 stars 18 forks source link

Making a better poemgame #68

Closed Bronya-Rand closed 1 year ago

Bronya-Rand commented 1 year ago

This PR does the following

(Elk, if by any chance you read this PR, get some water and a pillow because you might rage at this.)

Elckarow commented 1 year ago

breathes in... and out

if it works, then go for it there are a couple things that i ain't happy with tho

image

-the exec part straight up won't work. instead of storing the appeals in a list, add a new parameter name to the Chibi constructor and store the object in a dict with the name as its key. that way you can replace this ugly exec with chibis[ch1_choice[0]].charPointTotal += 5

-goofy ahh sorting code poemwinner[chapter] = max(chibis, key=lambda c: chibis[c].charPointTotal ) works way better (with the dict thing i talked about just before) plus the code won't work if there are more than 3 appeals

Elckarow commented 1 year ago

plus the code won't work if there are more than 3 appeals

the code you wrote.... just clarrifying

Pseurae commented 1 year ago

This is a much needed change, and I'll contribute however I can because the vanilla code is just painful to look at Maybe you could salvage something from this incomplete mess https://github.com/dokimods/poemgame

Elckarow commented 1 year ago

i've already sent this to weiss alsongside the new poem response system here, if you wanna have a look pseurae

new_poemgame.zip