Bronya-Rand / DDLCModTemplate2.0

A new template for producing DDLC mods that adhere to Team Salvato's guidelines based off DDLC itself.
58 stars 18 forks source link

Fix some problems about invert and tear effects in effects.rpy #80

Closed JimenezLi closed 6 months ago

JimenezLi commented 7 months ago

Fix two problems:

The size of effect tear and invert didn't match the window size

Basically, a tear effect looks like this before modifying. It doesn't match the window.

screenshot0014

I change the screenshot_srf function, and now the screenshot size is right.

screenshot0017

Remove hide_windows_enabled function

This function causes the game to raise an exception, when trying to save after a tear screen. For example, after running the following code, trying to save will crash the game. Full Bug Report

show screen tear(20, 0.1, 0.1, 0, 40)
play sound "sfx/s_kill_glitch1.ogg"
$ pause(0.75)
stop sound
hide screen tear

Besides, the Original Script Files already use window hide(None) to hide window, so this function is not necessary.

Bronya-Rand commented 6 months ago

I wouldn't really know anyone who would save in the midst of a tear screen to be honest, however, I am still willing to apply the PR as-is after some verifying, though I will see to when I have time to test the PR sometime in this week.

Elckarow commented 6 months ago

I wouldn't really know anyone who would save in the midst of a tear screen

the problem is that the tear effect is saved even after it's hidden, to allow rollback

Bronya-Rand commented 6 months ago

Merging for now as it seems to work.

Elckarow commented 6 months ago

gotta love it when your pr reviews are completely ignored