Closed JimenezLi closed 6 months ago
I wouldn't really know anyone who would save in the midst of a tear screen to be honest, however, I am still willing to apply the PR as-is after some verifying, though I will see to when I have time to test the PR sometime in this week.
I wouldn't really know anyone who would save in the midst of a tear screen
the problem is that the tear effect is saved even after it's hidden, to allow rollback
Merging for now as it seems to work.
gotta love it when your pr reviews are completely ignored
Fix two problems:
The size of effect
tear
andinvert
didn't match the window sizeBasically, a tear effect looks like this before modifying. It doesn't match the window.
I change the
screenshot_srf
function, and now the screenshot size is right.Remove
hide_windows_enabled
functionThis function causes the game to raise an exception, when trying to save after a tear screen. For example, after running the following code, trying to save will crash the game. Full Bug Report
Besides, the Original Script Files already use
window hide(None)
to hide window, so this function is not necessary.