search

Bronya-Rand / DDLCModTemplate2.0

A new template for producing DDLC mods that adhere to Team Salvato's guidelines based off DDLC itself.
58 stars 18 forks source link

Ren'Py Version Check for Screenshots (Maintenance Branch) #9

Closed Bronya-Rand closed 3 years ago

Bronya-Rand commented 3 years ago

Versions Affected

Any Ren'Py 7.4+ DDLC Mod

Issue Description

After 7.3.5, the Ren'Py code changed the method taking screenshots in the game works causing issues with certain effects in the game like screen tear when ran by a modder's copy in 7.4.0 or higher.

Cause

The cause of this is due to depreciation, or moved/removed feature in the screenshot() define in swdraw.py for fullscreen_video that has been present since 6.99.12.4 (Ren'Py 6) up to 7.3.5, when Ren'Py has officially removed support for fullscreen_video in the define itself. Since it takes less arguments than what Ren'Py 6 and older Ren'Py 7 had in the files, it will error out due to being given 2 arguments rather than one.

Solution

The solution appears to be modifying effects.rpy to check whether the version of Ren'Py running is 7.4 or higher to use the new draw call and if not to use the older draw call from DDLC itself. This should fix the 2 argument screenshot error for future builds of the mod template and higher versions of Ren'Py.

This PR is related to PR #8