Closed Bronya-Rand closed 5 years ago
Type of Issue: Bug/Instability State: Critical/Fatal Versions Affected: DDML 5 (Mac OS)
Update State: Unknown
Fixes Applied:
Update 2
Pending re-write on the macOS side for DDML.
Issues to fix:
[x] Switch zipfile
to shutil.copytree
(As python counts DDLC.app as a directory) for both DDLC and Mod ZIP Directory
[x] Add fix for pathm
and pathmz
so it doesn't default to E:\Downloads
(odd thing to occur)
[x] Re-write DDML for macOS running
Fixes Applied:
Re-write of DDML for macOS fixed Issue #5 .
Additional Notes: Update 2 To-Do Completed macOS Version of DDML must be written in macOS due to Windows breaking renpy.app
To-Do:
[ ] Add Additional Variables to change_directory.rpy from DDML 5 Windows.
[x] Test if removing lib/darwin works as it is part of renpy.app and may lower disk space. (In 5.1.5-Mac Branch)
[ ] Implement Steam Support
[x] Implement Bug Fixes from 5.1.5 Branch
Mac OS Testing Notes:
Apple does not allow writing of DDLC.app via the Application. This causes Ren'Py to execute the mod, but will be missing either singleton if not avail or throw DDLC asset error.
After the criteria is met along with any other mod criteria, DDLC should boot with the Mod Content in Mac OS.
Checking to see if copying .rpa from DDLC.app to Content Resources Autorun Game will work via Python
Darwin-x86 folder in lib can be safely removed to lower Mac's total space capacity
Build Success.
Variables need to be changed a bit to avoid DDLC ZIP and Mod ZIP reading test in Windows.
Note to Add: @alicerunsonfedora beta tested ML and Catalina Dev Release (Beta) has issues with Ren'Py running the ML SDK while Mojave works just fine. Will note this in case Catalina goes global to update MacOS ML
Note: MacOS auto-extracts ZIPs unless you use Chrome/Firefox or tell Safari not to open "safe" files in Preferences and uncheck the box. Due to this, MacOS Release of ML will require 2 additional inputs surrounding if the user downloaded DDLC off Chrome/Firefox or Safari with either Safe files On or Off and if the OS is El Capitan or lower or Sierra or Higher (Sierra -> Mojave ATM as Catalina Beta has issues) before extracting or copying.
When shutil.copytree is in effect, it will only copy the files in the folder and not the folder itself (e.g. Mod Folder name is TTR but temp folder gives out only the game folder or .rpa/rpyc's. This has been resolved now, but to keep note to relabel a bit.
Should be finished next day extract or soon today for a open 3 platform release
Additional Notes: Auto-Extract is present on all OS X and Mac OS releases prior to OS X 10.5 Snow Leopard so OS feature will be Obsolete. Browser Check will still be shown and asked due to auto-zip on Safari vs Chrome which downloads ZIPs as plain .zip with no extract
Status: Beta Release/Release Good to Go Versions Affected: DDML 5 (Mac) Mac OS/OS X Compatibility: OS X 10.5 Snow Leopard to OS X 10.14 Mojave Mac Notes: 10.15 Requires Notarizing which is absent in 7.3.2 (current Ren'Py ML SDK Mod). Downgrade to 6.99 will be needed for Catalina ONLY. Mojave and lower can still run 7.3.2
Mac OS Version of DDML may have more instabilities than Windows/Linux due to me not running a Mac with MacOS. Will patch any Mac Errors as best with the Mac OS Version of ML