Python-TK Error when canceling (Linux/Mac OS)

Bronya-Rand / DDML

Mod Launcher for Doki Doki Literature Club using the Ren'Py SDK

Other

9 stars 3 forks source link

Python-TK Error when canceling (Linux/Mac OS) #5

Closed Bronya-Rand closed 5 years ago

Bronya-Rand commented 5 years ago

Type of Bug: Ren'Py SDK Bug State: Low Versions Affected: DDML 5 (macOS & Linux)

If the user cancels during choosing a directory, Ren'Py, not DDML itself will throw a python-tk error on macOS and Linux.

Additional Notes: Tom says he forgot to handle cancel in Ren'Py itself that throws the python-tk error. Not a bug in DDML but a Ren'Py bug. May be fixed but will be announced in the new patch.

Related Issues: #1, #3

Bronya-Rand commented 5 years ago

Update:

Versions Fixed: DDML 5 (macOS) Versions Still Affected: DDML 5 (Linux) - Minor Bug but still set by default.

Pending Fix from RenpyTom to implement to ML 5.

Bronya-Rand commented 5 years ago

Additional Notes:

DDML 5 Linux despite showing a python-tk error, will still set the default directory to /home/User/Desktop rather than break the SDK. Will be known in Reddit Release about this bug.

Bronya-Rand commented 5 years ago

Fixes Applied:

New tkaskdir.py and change_directory.rpy files from "renpy/renpy" channel by RenpyTom

Base Issue on renpy/renpy: https://github.com/renpy/renpy/issues/1678

Versions Fixed: DDML 5 (Linux)