Bronya-Rand / DDModDocker

Codename: Snowrance. A WIP mod launcher integrated into DDLC/Ren'Py.
GNU Affero General Public License v3.0
19 stars 2 forks source link

SGAB breaks DDMD #2

Closed Retrolovania closed 2 years ago

Retrolovania commented 2 years ago

Alright, so, tried Sayori Gets a Burger with this new application, and it displayed an error:

I'm sorry, but errors were detected in your script. Please correct the
errors listed below, and try again.

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 517: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    style_prefix "main_menu"
    ^

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 748: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    use game_menu(_("About"), scroll="viewport"):
    ^

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 789: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    use file_slots(_("Save"))
    ^

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 796: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    use file_slots(_("Load"))
    ^

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 932: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    if renpy.mobile:
    ^

File "game/mods/Sayori Gets a Burger/game/screens.rpy", line 1118: Line is indented, but the preceding tag statement does not expect a block. Please check this line's indentation.
    predict False
    ^

Ren'Py Version: Ren'Py 7.4.11.2266
Wed Mar 16 16:14:00 2022

I presume this is because this mod makes modifications to various areas in screens.rpy that deal with altering stuff in the settings menu that it must not be liking. The copy of the mod downloaded is from the original link posted in the Reddit and is confirmed to work separately, so best I can assume is that something regarding the Mod Selector/Docker not being happy about.

Bronya-Rand commented 2 years ago

Hi so after looking at the code, I found two things that were the main issue.

  1. It looks like somewhere during Ren'Py 7, the syntax for screens changed that may have caused some incompatibility issues with the current syntax SGAB has.
  2. After fixing it myself, it appears some of the main files are still missing from within the mod (few in scripts.rpa) so I will have to investigate that later.

This might require later DDMD version to ship as 6 and 7 only with 6 being 6 on and 7 being a mix of some 6 and 7 mods that are fully packaged or fully listed.

Bronya-Rand commented 2 years ago

If you are wondering how to return Mod Docker to stock settings, delete selectedmod.json in Mod Docker's base directory.

Bronya-Rand commented 2 years ago

Docker bug has been fixed. R6 mode will be planned later on after 1.0.0 is settled.

Bronya-Rand commented 2 years ago

Mod should now run fine under Mod Docker SE Edition. Closing Issue.