Brookke / Lorem-Ipsum-4

2017 SEPR project assessment 4
1 stars 0 forks source link

Adds multiplayer support #43

Closed jasonmash closed 7 years ago

jasonmash commented 7 years ago
jasonmash commented 7 years ago

Nice one @joeShuff! That's definitely a better way of doing it, thanks.

jasonmash commented 7 years ago

I've got a playable multiplayer game working now, feel free to try it out!

There's a bug I've not gotten round to fixing yet - it's to do with the PlayerSwitchScreen showing too soon after interacting with a clue when you've only got 1 interaction left before your go is over. It's not an easy fix due to the timeout of the speech box that the user needs to see. If anyone else wants to have a go at this feel free

Brookke commented 7 years ago

Not looked at the code, but could you just check to see if the list containing speechboxes is empty? and if so then change?

joeShuff commented 7 years ago

I'll have a go at tackling it @jasonmash. I'll be back in York soon. Will give me something interesting to do this evening

jasonmash commented 7 years ago

Potentially @Brookke - at the moment currentSnapshot.finishedInteraction(); is called once a conversation is finished, or when interacting with a clue. I'm not sure we've got an event for after the Clue speech box disappears we can put that code into. Shouldn't be too challenging to solve, just needs a bit more thought!

joeShuff commented 7 years ago

I see what you mean @jasonmash

joeShuff commented 7 years ago

Might be easier if we were to add the clue screen in. But for now, I'll just do when the dialog box is closed for now

beno11224 commented 7 years ago

Aside from the 'doc string' comments by Joe, this seems done doesn't it?

joeShuff commented 7 years ago

Yeah it does @beno11224

joeShuff commented 7 years ago

The only thing we could do is add the possible additions

joeShuff commented 7 years ago

Like, #50

beno11224 commented 7 years ago

k, u ok if i make a new branch to add things like that?

joeShuff commented 7 years ago

Go for it. Branch off of this branch, and create the PR to merge into this branch

joeShuff commented 7 years ago

This whole branch needs tests aswell. Poop