search

Brookke / SEPR-Assessment2

1 stars 6 forks source link

Joe rooms and transitions #62

Closed joeShuff closed 7 years ago

joeShuff commented 7 years ago

Closes #57 Closes #32

joeShuff commented 7 years ago

Created a pull request so the code can be reviewed by all. I would like as much feedback as possible so that I don't get too far ahead with the code and have to change too much.

Brookke commented 7 years ago

It looks great :) just the few comments I mentioned

joeShuff commented 7 years ago

I've found quite a nasty way of drawing the sprites correctly underneath a layer.

http://www.gamefromscratch.com/post/2014/05/01/LibGDX-Tutorial-11-Tiled-Maps-Part-2-Adding-a-character-sprite.aspx

Its not the first method where he creates a new tilelayer. It's the second method where he creates his own renderer.

jasonmash commented 7 years ago

Just tried out this branch, it looks amazing!

One small thing though is when you leave the island of interaction, I ended up in a black room? Think there might be a bug there?

Also when trying to get the project to build, it lost all of the build configurations, I think that's also partly why the CI tests are failing.

joeShuff commented 7 years ago

@jasonmash Thanks!

I havent had time to test every single room yet, I will take a look at that bug and fix it. Probably just a typo.

I have the configurations... These configurations are a right pain in the arse xD

joeShuff commented 7 years ago

@jasonmash Found why the island of interaction isn't working! I did put the wrong room number/not update it from the temporary number. Will fix it when I'm home

joeShuff commented 7 years ago

I am aware that some rooms' names write outside of the tag. I will fix that later. Tired

Brookke commented 7 years ago

@joeShuff would it make it easier if you were to get rid of the tag completely? and just do the text with a black boarder, by black boarder I mean like the bottom one on this

joeShuff commented 7 years ago

I'm not bothered about 'making it easier', that ends up making it boring. I will still take a look at it and as a last resort I will use it.

jasonmash commented 7 years ago

We should keep in mind the KISS principle the SEPR lecturers were on about:

KISS = Keep it simple, stupid

Brooke's approach seems simpler, therefore I'm in favour of doing that way, but if your current implementation works and doesn't need any more changes, let's use that.

jasonmash commented 7 years ago

How much work is left to do on this branch before it can be merged?

Let me know once you've got the tests sorted @joeShuff, and I'll give this branch a full review

joeShuff commented 7 years ago

@jasonmash Not much left addition wise. I might even be done. Just need to tidy some things up, document the code and get tests working

joeShuff commented 7 years ago

So I think this is now ready for merge so I'd like a review from everyone as it is quite a large addition... @Brookke @jasonmash @TheProgrammingDuck @beno11224 @Penguin-Benjamin