Brooooooklyn / canvas

High performance skia binding to Node.js. Zero system dependencies and pure npm packages without any postinstall scripts nor node-gyp.
https://vercel.skia.rs
MIT License
1.78k stars 76 forks source link

Indicate supported version in package.json #908

Open lostfictions opened 1 month ago

lostfictions commented 1 month ago

Node 16 has been EOL for over a year (since September 11 2023), and hasn't been tested in CI since #743 was merged last year. The engines field in package.json should reflect this as well.

This should help prevent introducing accidental behaviour changes -- for example, it looks like https://github.com/Brooooooklyn/canvas/pull/889 was merged because it was causing an error on Node 10 (EOL since 2021) and unfortunately it subtly changes the behaviour of transformPoint (it's no longer possible to call it with a w of 0). It's possible 0 is not a valid value for w anyway, but in general these kind of subtle differences can cause a library to work differently for users from version to version and it would be nice to avoid unnecessary changes like this.