fix: memory leak in Image

Brooooooklyn / canvas

High performance skia binding to Node.js. Zero system dependencies and pure npm packages without any postinstall scripts nor node-gyp.

https://vercel.skia.rs

MIT License

1.78k stars 76 forks source link

Closed Brooooooklyn closed 2 weeks ago

Brooooooklyn commented 2 weeks ago

There 2 leak points in the Image class.

The Env::create_reference was wrong in NAPI-RS, related pr: https://github.com/napi-rs/napi-rs/pull/2347, change to the Ref::new can resolve it.
The PromiseRaw::catch callback was leaked, it cause the whole Image objects not be GCed, it was fixed in https://github.com/napi-rs/napi-rs/pull/2348

Brooooooklyn commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite

Brooooooklyn commented 2 weeks ago

Nov 7, 1:27 AM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 7, 1:27 AM EST: A user merged this pull request with Graphite.

fengmk2 commented 2 weeks ago

感谢修复，公司内部通过压测验证修复有效！☆(￣▽￣)/$:*