search

Brown-University-Library / OLD-ARCHIVED_iip-production

3 stars 9 forks source link

CSS change not working in dev branch #135

Closed emylonas closed 3 years ago

emylonas commented 3 years ago

Adam just accepted pull request #134 and installed on dev. The changes are not showing up when I check them on the dev branch.

So: I can see the changed file in github: https://github.com/Brown-University-Library/iip-production/blob/dev/iip_smr_web_app/static/iip_search_app/css/tei_custom_elements.css (The change to look for is on line 122 content: "((" attr(ref);)

However, when I view a file that should be using the new CSS, such as https://dlibwwwcit.services.brown.edu/iip/viewinscr/masa0298/ I see ((char)) in the display instead of ((phoen-mem)) or ((phoen-wau))

When I inspect that bit of the web page, it looks as if the CSS is coming from this file: https://dlibwwwcit.services.brown.edu/django_media/iip_student_dev_media/iip_search_app/css/tei_custom_elements.css and not the file in iip_smr_web_app

So something is getting confused. I can't find why the css file is being called from /django_media/iip_student_dev_media instead of the current repository. I've cleared my cache and reloaded the page.

emylonas commented 3 years ago

The production version seems to be using the same CSS, https://library.brown.edu/django_media/iip_student_dev_media/iip_search_app/css/tei_custom_elements.css

atbradley commented 3 years ago

I've updated the site on dlib. Is this what you're expecting to see? image

emylonas commented 3 years ago

Yes!!! that's it.

On Wed, Aug 4, 2021 at 2:48 PM Adam Bradley @.***> wrote:

I've updated the site on dlib. Is this what you're expecting to see? [image: image] https://user-images.githubusercontent.com/71141/128237704-7b1321dc-7e54-4f70-a04d-7da9f8339fd5.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Brown-University-Library/iip-production/issues/135#issuecomment-892890085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOA7ZPU635ILUHX4QHHNUTT3GDRPANCNFSM5BGVVJEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

emylonas commented 3 years ago

this can move to production when you are able to do so.

On Wed, Aug 4, 2021 at 2:56 PM Mylonas, Elli @.***> wrote:

Yes!!! that's it.

On Wed, Aug 4, 2021 at 2:48 PM Adam Bradley @.***> wrote:

I've updated the site on dlib. Is this what you're expecting to see? [image: image] https://user-images.githubusercontent.com/71141/128237704-7b1321dc-7e54-4f70-a04d-7da9f8339fd5.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Brown-University-Library/iip-production/issues/135#issuecomment-892890085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOA7ZPU635ILUHX4QHHNUTT3GDRPANCNFSM5BGVVJEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

emylonas commented 3 years ago

This looks ok on production, closing.