relationship-deletion doesn't work

[birkin]

Error message: "'rfrnc_id' referenced before assignment".

Exception Location:

• disa_dj_project/disa_app/lib/v_data_relationships_manager.py, line 113, in manage_relationships_delete
• line 113: return rfrnc_id

More info in error email.

[birkin]

• This could be a data issue, in that perhaps something didn't get saved properly, or some subsequent db entry didn't get properly auto-created.
• Though if that is the case, how that could have happened could be a code issue (i.e. transactions exist to prevent this sort of thing).

[birkin]

Issue confirmed June 1.

The problem...

• Currently the relationship-deletion code needs a data-element it is not receiving.
• It needs:
  • relationship-id
  • reference-id (the item-record-id)
  • user-id
• It's receiving the relationship-id from from a parameter that's part of the relationship-delete-api-call.
• It's receiving the user-id as part of the regular authentication-and-session architecture.
• It is NOT receiving the reference-id.
• It's expecting to find the reference-id as part of a json payload in the relationship-DELETE-api-call. That payload is empty.
• Here is where the code attempts to extract the reference-id. It's looking for a key of "section" for unknown historical reasons.

Solution...

• In the same file, in the relationship-CREATION-api-call, here, the payload does contain that ("section") reference-id (because relationship-creation is working).
• Plan: find the js making the relationship-delete-api-call and add that ("secion") reference-id as part of the payload.

---

Additional note: There are a couple of other minor code changes required for improved relationship-tests to run properly. That's mostly in-place in a branch. But this is unrelated to actually getting the relationship-deletion to work properly.

[end]

[birkin]

fixed in commit ba609f12e032bf87a919e0aa5d4ffaf8def17bca.