search

Brown-University-Library / disa_dj_project

MIT License
2 stars 3 forks source link

DB change/occupation #204

Closed elizabethyalkut closed 4 months ago

elizabethyalkut commented 5 months ago

Didn't touch the tests or the models_sqlalchemy files, but otherwise relied on the age-category branch for direction. The field exists! It is obviously not yet saving anything I put in it, but the front-end works. Your problem now, @prashleigh?

prashleigh commented 4 months ago

Checked it: it works! I moved it along some more—will put my contributions in another PR

elizabethyalkut commented 4 months ago

Can I ask why you want to open a new PR instead of continuing on this one, just so I understand your reasoning?

prashleigh commented 4 months ago

Because maybe I don't understand the github metaphor? I was assuming that a draft PR is like "I did this—check it out". And that responses to that are corrections/elaborations on that original action. I figured that if I did something that was another contribution, that required someone else's review, that would be another PR.

That was my logic and having said that, I really don't know if this is the way that things are supposed to be done, and am not married to it.

On Thu, Feb 8, 2024 at 9:51 AM Elizabeth Yalkut @.***> wrote:

Can I ask why you want to open a new PR instead of continuing on this one, just so I understand your reasoning?

— Reply to this email directly, view it on GitHub https://github.com/Brown-University-Library/disa_dj_project/pull/204#issuecomment-1934283723, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIX6EH6FPORBERLQ6FC3K3YSTRAVAVCNFSM6AAAAABCVIBCD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGI4DGNZSGM . You are receiving this because you modified the open/close state.Message ID: @.*** com>

-- E. Patrick Rashleigh | Head of Digital Scholarship Technology Services Brown University Library | Center for Digital Scholarship 401.863.5076 | @.***

elizabethyalkut commented 4 months ago

A draft PR, as I understand it, is just a PR that isn't finished but where the contributor(s) want feedback in order to move it along in the process. That PR ideally should then get further contributions to make it review-ready. I think that since your change are part of implementing mine, in this example, they should be in one PR. Clear as mud?

prashleigh commented 4 months ago

Ummm ... sure!

On Thu, Feb 8, 2024, 10:52 AM Elizabeth Yalkut @.***> wrote:

A draft PR, as I understand it, is just a PR that isn't finished but where the contributor(s) want feedback in order to move it along in the process. That PR ideally should then get further contributions to make it review-ready. I think that since your change are part of implementing mine, in this example, they should be in one PR. Clear as mud?

— Reply to this email directly, view it on GitHub https://github.com/Brown-University-Library/disa_dj_project/pull/204#issuecomment-1934419355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIX6EBMHWICME6KQJ62CFLYSTYDPAVCNFSM6AAAAABCVIBCD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGQYTSMZVGU . You are receiving this because you modified the open/close state.Message ID: @.*** com>