search

Brown-University-Library / disa_dj_project

MIT License
2 stars 3 forks source link

Volume and Pages fields on Records #214

Open elizabethyalkut opened 2 months ago

elizabethyalkut commented 2 months ago

Needs tests; see my email from 04 April 2024, re:column type concerns.

elizabethyalkut commented 2 months ago

Okay! We discussed this in email so the column type is just text even though that's "dirty". I do not know how to write the tests for these fields and I hope @birkin will, out of the kindness of his heart, help. I tested the fields on my local and they seem to work; @prashleigh, please confirm.

The SQLLite commands I used were ALTER TABLE `4_references` ADD COLUMN volume TEXT; ALTER TABLE `4_references` ADD COLUMN volume_pages TEXT;

I am of course very ready to be corrected in the niceties of adding columns!

elizabethyalkut commented 1 month ago

Approved without help text at SR meeting 23 May 2024.