search

Brown-University-Library / ttwr

This is the django app that runs the Theater That Was Rome project website.
1 stars 5 forks source link

Book pages not displaying #174

Closed emylonas closed 8 years ago

emylonas commented 8 years ago

http://library.brown.edu/projects/rome/books/257322/?book_list_page=2 if you click on a page, you get a 500 error.

the pages show up in the BDR.

I checked to see if it was maybe a Buonnano book, but it doesn't seem to be. Other book pages are displaying ok.

jrhoads commented 8 years ago

From the Logs stderr: [ pid=29164, time=2016-07-29 14:41:30,413 ]: Internal Server Error: /projects/rome/books/257322/257594/ stderr: Traceback (most recent call last): stderr: File "/opt/local/django_projects/projects/env/lib/python2.6/site-packages/django/core/handlers/base.py", line 111, in get_response stderr: response = callback(request, _callback_args, *_callback_kwargs) stderr: File "/opt/local/django_projects/projects/rome_app/views.py", line 170, in page_detail stderr: if 'Buonanno' in book_json['note'][0]: stderr: KeyError: 'note'

It looks like the view is trying to access a field in a dictionary that does not exist.

On Fri, Jul 29, 2016 at 12:23 PM, Elli Mylonas notifications@github.com wrote:

http://library.brown.edu/projects/rome/books/257322/?book_list_page=2 if you click on a page, you get a 500 error.

the pages show up in the BDR.

I checked to see if it was maybe a Buonnano book, but it doesn't seem to be. Other book pages are displaying ok.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Brown-University-Library/ttwr/issues/174, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcoaAVI0qmzB4nGPBUWFNrLfAV0l_qzks5qaikPgaJpZM4JYWiC .

emylonas commented 8 years ago

ack - this book has no note elements in its MODS. We just pushed a change that is looking for a value in that field. So it's failing. Solution: check for existence of field or remove feature for now. Feature isn't behaving properly but ideally would do so. It's not harming any pages other than the books which have no <mods:note>

bcail commented 8 years ago

fixed.