search

Brown-University-Library / ttwr

This is the django app that runs the Theater That Was Rome project website.
1 stars 5 forks source link

Adding Documents and Shop enhancements #294

Closed zaaakk closed 5 years ago

zaaakk commented 5 years ago

-new "document" object for associating with shops -shops have associated books, prints, and documents

bcail commented 5 years ago

@zaaakk I'll look at this more, but could you please make it just one db migration? In your project, you can delete all the new migrations you've added, and then run makemigrations, and it will lump them all together in one.

Also, I don't see tests. We'll want to add tests for the new functionality.

Let me know if you want me to help with anything. Thanks.

zaaakk commented 5 years ago

sure, no problem. going to add tests as well.

zaaakk commented 5 years ago

Hey Ben, I was still having trouble with that method of consolidating the migrations, so I tried the squashmigrations command which consolidated them to one. I left the old ones in there as recommended in the documentation, but I think they can be removed later with no trouble. I added a test for the document object views, let me know if there are any other areas you think could use a test.

bcail commented 5 years ago

@zaaakk I see the squashed migration that replaces the old existing migrations, which is OK, but what I'm talking about are the new migrations from this PR (0008, 0009, ...). There should only be one new migration that you're adding in this PR. You can delete 0008, 0009, ... migrations (up through 0016) and then run makemigrations again, and it should generate one new 0008 migration that adds all the fields for this PR.

Also, I see some binary files (17532819.pdf, the files in media/, ...). Please remove those from git. (You might want to add the media directory to .gitignore, so it doesn't want to keep adding those files.)