search

Brown-University-Library / usepweb_project

MIT License
0 stars 5 forks source link

Images that are included by URL to external site don't have thumbnail (.5day?) #57

Open emylonas opened 4 years ago

emylonas commented 4 years ago

It's possible that the the USEP templates assume that all images are local, and are not able to display a thumbnail in the collection list.

Inscription with external image link: https://usepigraphy.brown.edu/projects/usep/inscription/MA.Camb.HU.Sack.G.2003.97/

In collection view, it's the last one: https://usepigraphy.brown.edu/projects/usep/collections/MA.Camb.HU.Sack/

The image URL is: http://nrs.harvard.edu/urn-3:HUAM:DDC111355_dynmc?width=3000&height=3000

The thumbnail view is looking for: https://library.brown.edu/usep_images/http://nrs.harvard.edu/urn-3:HUAM:DDC111355_dynmc?width=3000&height=3000

atbradley commented 3 years ago

@emylonas @birkin My recent commit (live on dev) seems to be working, and doesn't seem to be breaking anything else after a quick glance.

emylonas commented 3 years ago

Did Scott fix this?

emylonas commented 3 years ago

@atbradley This is working well.

I noticed something however, which may just be because this is the dev site. When you go to the inscription itself, https://dlibwwwcit.services.brown.edu/projects/usep/inscription/MA.Camb.HU.Sack.G.2003.97/ the image overlaps the text. It's happening with locally served images as well. https://dlibwwwcit.services.brown.edu/projects/usep/inscription/MA.Camb.HU.Sack.L.1932.56.129.r/

It doesn't happen with the production site - https://usepigraphy.brown.edu/projects/usep/inscription/MA.Camb.HU.Sack.L.1932.56.129.r/