search

Brown-University-Library / usepweb_project

MIT License
0 stars 5 forks source link

updates django 1.9.x to 1.11.x #68

Closed birkin closed 3 years ago

birkin commented 3 years ago
jrhoads commented 3 years ago

I would suggest removing the commented code from the python and template files.

birkin commented 3 years ago

I would suggest removing the commented code from the python and template files.

@jrhoads not being obstinate! I agree -- but want to leave them in the template file for now, cuz it was so useful when debugging. I had initially used the wrong attribute & was able to immediately see the issue when comparing my incorrect updated code to the previous commented-out code. Here's an example. Once this is released and there are more eyes on it for a while, I'll remove those comments.

jrhoads commented 3 years ago

@birkin I think that is a fine practice for dev but I would not recommend leaving it in for code going in to production. Worth a discussion.

That said, I know each project has it's own flow and I do not want to hold that up. Will merge in 10 if I don't hear anything else.