BrownBiomechanics / SlicerAutoscoperM

This 3D Slicer extension enables users to perform image registration.
https://autoscoperm.slicer.org
MIT License
1 stars 4 forks source link

Transformation Update #113

Closed NicerNewerCar closed 3 months ago

NicerNewerCar commented 4 months ago
amymmorton commented 4 months ago

building now... and will confirm, but a comment on the commit message re: splitting the .tfm: We do want all three variants: bone.tf boneScaleOnly.tfm and boneTransOnly.tfm

NicerNewerCar commented 4 months ago

building now... and will confirm, but a comment on the commit message re: splitting the .tfm: We do want all three variants: bone.tf boneScaleOnly.tfm and boneTransOnly.tfm

Okay, I will update this now to include the {bone}.tfm again

amymmorton commented 4 months ago
NicerNewerCar commented 4 months ago
  • [ ] change bone_t to inv(bone_t)

Should this also apply to the naming of the bone_scale (ie. inv(bone_scale))

  • [ ] the DICOM2AUT tfm is combined transform of the image position to aut AND RAS->LPS - suggest naming explicitly? (if user segments in mimics and applies this tform- (staying LPS) to the bone model or a cs gen from the anatomy it will be erroneous.

Would something like DICOM(RAS)2AUT(LPS) work or were you thinking of something else?

amymmorton commented 3 months ago

The bone_t.tfm are in RAS not LPS (name it explicitly?) (ground truth data prev sent 7/16 vs this branch) image

the output tra (with LPS-RAS) tform applied is correct!

image image