BrownDwarf / gollum

A microservice for programmatic access to precomputed synthetic spectral model grids in astronomy
https://gollum-astro.readthedocs.io/
MIT License
20 stars 5 forks source link

Warnings in tests #114

Closed DanielAndreasen closed 3 months ago

DanielAndreasen commented 3 months ago

I get two warnings when running the tests, and this is how I fixed them:

All other tests now runs without errors for me.

Review link: https://github.com/openjournals/joss-reviews/issues/6601

Sujay-Shankar commented 3 months ago

The most recent commit should have fixed both of these changes. The radial velocity method is actually a little deceptive, as it just seems to be an in-place setter method but doesn't actually change the spectral axis, which is what gollum wants. We actually want to use shift_spectrum_to(radial_velocity=rv*u.km/u/s) and this does the desired behavior of shifting the spectral axis. The tutorial should now work with this change.