search

BrownDwarf / gollum

A microservice for programmatic access to precomputed synthetic spectral model grids in astronomy
https://gollum-astro.readthedocs.io/
MIT License
21 stars 5 forks source link

Metallicity support for Sonora Bobcat models #6

Closed gully closed 2 years ago

gully commented 3 years ago

Eventually the Sonora-Bobcat models will have metallicity, C/O ratio, and possibly other dimensions like f_sed. We want to be able to read in those future metallicity grids, while maintaining support for the extant solar-metallicity grid.

Future grids may have irregular sampling in the grid parameters. Irregular sampling is a smart strategy for grappling with high dimensional spaces, but it does add some complexity to how we read in the data and how to make the dashboard sliders identify and "snap-to" the closest gridpoint.

@astrocaroline has provided some pre-release grids with metallicity for development and evaluation purposes. To read in this grid we may want to move towards a glob and filename comprehension approach to identify eligible grid points rather than pre-specify the grid points. I am starting an experimental feature branch in anticipation that these changes may be backwards breaking...

gully commented 3 years ago

Hmmm, I just looked at the metallicity and C/O grids provided by Caroline. There are a few small but pesky differences: the directory is compressed but the individual files are not, the file name extensions have C/O listed listed only if it is different from 1.0. These are all subtle differences, but they add up to finite coding overhead, and all of that effort is destined be supplanted when the paper is released with the final version anyways.

Other innovations will need to happen. It currently takes ~30 seconds to read in the solar-metallicity Sonora grids. We will multiply that file I/O by a factor of 4, so up to 2.5 minutes to read in the whole grid. There are definitely ways to speed this I/O up.

I am almost inclined to wait on adding metallicity until the final grid is actually public, or its final form can be provided in advance. This may seem nitpick-y, and it sort of is, but there is a diminishing returns to investing lots of time in dealing with formatting that will vanish in a few weeks or month. On the other hand, if the final grids won't be public for months, maybe it is worth taking an early look. Thoughts welcome.

gully commented 3 years ago

Hooray! The full Sonora models are public on Zenodo. We will accomplish this once we get support for reading in the whole new model grid.

gully commented 2 years ago

This task is assigned to @jiayi-cao and is part of our JOSS Submission milestone.

gully commented 2 years ago

Closed by PR #30