Closed samirans89 closed 1 year ago
@shaikhalid -
suffix
param which is only allowed under additionalSnapshots
. With the current logic, if we add | Page 1
to the first page name, then all subsequent pages will show up as <PDF Name> | Page 1 | Page <X>
. Any way to get this done built-in by Percy config file itself (and avoiding any external logic)?waitForTimeout - An amount of time to wait before capturing a snapshot
. For graphic intensive PDF's, do we allow users to specify a waitForTimeout
in the pdf-docs-run-info-config
file which we apply to all pages in the Percy config file?We can do some research and code corresponding waits accordingly
- I will add
- I will need to check the code for this. I think one way is to use the API and check the number snapshots and the number accordingly so we avoid extra logic.
- I have an interesting solution for this. Like Percy sensitivity we can allow the user to set the PDF time to three level or custom i. only text ii. Moderate graphics iii. Graphic intensive
We can do some research and code corresponding waits accordingly
Aligned with #1 and #3. Need to understand #2 better.
- I will add
- I will need to check the code for this. I think one way is to use the API and check the number snapshots and the number accordingly so we avoid extra logic.
- I have an interesting solution for this. Like Percy sensitivity we can allow the user to set the PDF time to three level or custom i. only text ii. Moderate graphics iii. Graphic intensive
We can do some research and code corresponding waits accordingly
Aligned with #1 and #3. Need to understand #2 better.
Hey @shaikhalid - I'm merging this PR for now, since we have an external call today. It's okay to add PR to enhance / optimise the working further. I'll try to schedule a meeting with Product too to go over this implementation.
Initial Setup was very easy. It worked without any problems.