browser-sync package not installing with yarn

BrowserSync / browser-sync

Keep multiple browsers & devices in sync when building websites. https://browsersync.io

https://discord.gg/2d2xUThp

Apache License 2.0

12.17k stars 756 forks source link

browser-sync package not installing with yarn #1475

Open romanmarkelov opened 6 years ago

romanmarkelov commented 6 years ago

Issue details

browser-sync package not installing with yarn

Steps to reproduce/test case

yarn add browser-sync

Please specify which version of Browsersync, node and npm you're running

Browsersync [2.22.0]
Node [9.3.0]
Npm [5.6.0]
Yarn [1.3.2]

Affected platforms

[10.12.6 ] OS X

Open same issue in yarn repository

dmbdesignpdx commented 6 years ago

I, too, am having the same problem. Also with updating.

Node: 8.9.3
Browser-Sync: 2.23.1
Yarn: 1.3.2
macOS: 10.13.2

When running yarn upgrade browser-sync and after removing, then running yarn add -D browser-sync, I got this both times:

[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
⠁ 
⠁ 
[1/2] ⠂ fsevents
[-/2] ⠈ waiting...
[-/2] ⢀ waiting...
[-/2] ⠈ waiting...
[2/2] ⠈ uws
[-/2] ⠈ waiting...
[-/2] ⠈ waiting...
[4/4] 📃  Building fresh packages...
[-/2] ⠁ waiting...
[2/2] ⠁ uws
[-/2] ⠁ waiting...
[-/2] ⠁ waiting...
[-/2] ⠁ waiting...

jonnitto commented 6 years ago

The same here. It works until version 2.19.0. Any version higher it doesn't work anymore.

dmbdesignpdx commented 6 years ago

Update: I can't add any new packages without this issue happening and it appears to revolve around Browser-Sync:

Removing Browser-Sync allows me to install new packages without a problem
Reverting to an older version of Browser-Sync (2.18.3) also allows me to install new packages without a problem

oviava commented 6 years ago

@dmbdesignpdx try this https://github.com/yarnpkg/yarn/issues/5131#issuecomment-358956066.

dmbdesignpdx commented 6 years ago

After great patience, digging, and input from the Yarn team; there may be a simple fix. This issue might have to do with uws being out-of-sync with node-gyp.

Reinstall/install node-gyp by running npm install -g node-gyp and see if that takes care of it.

shakyShane commented 6 years ago

thanks for the update @dmbdesignpdx - it's a shame this has happened in the first place, and i'm seriously considering moving away from socket.io because of this.

I absolutely detest packages that require building in the environment they are installed - I understand why, but every time I've ever included such a package it's resulted in these types of issues :(

I believe uws is used when perf is an absolute must - but in reality Browsersync does not need screaming performance, no-where near in fact.

romanmarkelov commented 6 years ago

I upgraded yarn to 1.5.1. today and browser-sync installed without mistakes.