search

BrowserWorks / Waterfox-Classic

The Waterfox Classic repository, for legacy systems and customisation.
https://classic.waterfox.net
Mozilla Public License 2.0
175 stars 34 forks source link

Switch to Safebrowsing v4 on Desktop builds #103

Closed buttercookie42 closed 2 years ago

buttercookie42 commented 2 years ago

The rollout of Safebrowsing v4 in Firefox happened right during v56, but was controlled via a system add-on and not made permanent until v57. The old v2-API that Firefox was using until then subsequently stopped working at some point in 2018. (Though unless you supply an API key, which Waterfox by default doesn't, it wouldn't work either way, anyway.)

This is based along the lines of https://hg.mozilla.org/mozilla-central/rev/bca021fc3073, but I created the patch from scratch based on Waterfox's current set of safebrowsing prefs.

Android likely needs a few more bugfixes backported (and currently doesn't build anyway), so this only switches the Desktop prefs.

Note that Waterfox includes bug 1336915, so unless explicitly supplying an API key during building (which you don't), Safebrowsing will remain turned off internally and no API requests will be made to Google.

MrAlex94 commented 2 years ago

Awesome, thanks for this.

buttercookie42 commented 2 years ago

Awesome, thanks for this.

You're welcome, although like I said – without a corresponding API key Safebrowsing will remain turned off either way, so for now this one is really just to shorten my personal set of custom build patches a little bit :-)