If I try to run Waterfox with --enable-debug enabled, I'm immediately hitting some assertions in JS code. These two commits fix them, allowing Waterfox to successfully start up at least. (Eventually you might hit other assertions, e.g. I'm hitting one in NSS code on shutdown, and another somewhere when trying to open the devtools, but at least things are no longer completely broken.)
I've manually tested the trimLeft()/trimRight() aliases and they seem to continue working even with this new implementation.
If I try to run Waterfox with
--enable-debugenabled, I'm immediately hitting some assertions in JS code. These two commits fix them, allowing Waterfox to successfully start up at least. (Eventually you might hit other assertions, e.g. I'm hitting one in NSS code on shutdown, and another somewhere when trying to open the devtools, but at least things are no longer completely broken.)I've manually tested the
trimLeft()/trimRight()aliases and they seem to continue working even with this new implementation.