search

BrowserWorks / Waterfox-Classic

The Waterfox Classic repository, for legacy systems and customisation.
https://classic.waterfox.net
Mozilla Public License 2.0
175 stars 34 forks source link

Better module import support, part 1 (import.meta) #143

Closed buttercookie42 closed 1 year ago

buttercookie42 commented 1 year ago

@hawkeye116477's backporting of static module imports was quite thorough, so I only found some very minor things while going once over the related bugs to make sure we had a good baseline before backporting further module-related code.

Beyond that, this is mainly support for import.meta, associated preparatory patches (including some for the subsequent dynamic module import set of commits) and a few random other bugfixes I came across (mainly bug 1428489, 1382035 and 1451985 if I remember correctly).

adamp01 commented 1 year ago

@buttercookie42 - Ideal, I'm going to do a Classic release hopefully today so will get this merged in for that.

buttercookie42 commented 1 year ago

For the best compatibility effect you'd also want at least the subsequent part with the support for dynamic module import proper, though. (The third part for export * as namespace is at a guess more of a nice-to-have and probably not as critical for website compatibility.)

adamp01 commented 1 year ago

@buttercookie42 - Ok that sounds good, I'm just building this PR to test and then will merge hopefully within the hour. If you open the next PR later on today I can push back the release to Monday so we get that merged as well.