BrowserWorks / Waterfox-Classic

The Waterfox Classic repository, for legacy systems and customisation.
https://classic.waterfox.net
Mozilla Public License 2.0
175 stars 34 forks source link

Better module import support, part 2 (dynamic module import) #144

Closed buttercookie42 closed 1 year ago

buttercookie42 commented 1 year ago

Fixes at the very least #121 and #137.

6d8108b was a bit of a tight squeeze, because that patch led to Waterfox getting into an infinite loop while responding to an event handler. Thankfully f26277d completely rewrote the part of the code that was responsible for the infinite loop and therefore side-stepped this issue.

Otherwise I've been running with this code in my local build for approximatively two months now and haven't noticed any issues other the two things noted in #121, which of course have been fixed by now.

@adamp01

If you remember our conversation regarding 54273e0, then fa8d96d has some more details regarding the root cause of that particular bug.