search

BrowserWorks / Waterfox-Classic

The Waterfox Classic repository, for legacy systems and customisation.
https://classic.waterfox.net
Mozilla Public License 2.0
175 stars 34 forks source link

Revert changes #174

Closed adamp01 closed 1 year ago

adamp01 commented 1 year ago

Suspect these may be related to Windows actions breaking.

hawkeye116477 commented 1 year ago

It's marked as successful now, but apparently it's not true. That's the problem: nsprpub/pr/src/io/prsocket.c(310,41): error: incompatible integer to pointer conversion passing 'PROsfd' (aka 'long long') to parameter of type 'HANDLE' (aka 'void *') [-Wint-conversion].

adamp01 commented 1 year ago

It started breaking after the last release in August, but doesn't seem related to any individual PR as three PRs at the start of September all failed to build with a linking error. The nsprpub error started appearing about a month ago.