Open c33s opened 1 year ago
robbely
commented
1 year ago I've not been able to download anything from github (eg the assets sections) for over a week now on Waterfox Classic. When I click on the arrow to revel the assets, the arrow points downwards, but there are no files shown (again this is for all projects on github with downloads available).
walmar
commented
1 year ago Hello everybody.
The following steps seem to fix the latest loading issues with some GitHub page elements (at least since 2024-03-29) such as the Releases Assets list, the Repository Code files list and view, the Repository Go to file finder, the Commit diff content, the Dashboard, the account drop-down list, the comment edit history list, the editor and partly the action menu lists and the popovers.
zakius@polly.xpi after download.
When installing as browser feature (as listed on about:support page), the termination of Waterfox and step 2 is required.
If another version of the extension is installed to the extensions subfolder of the profile folder (as listed on about:addons page), then the one is loaded.
In addition to + 2024-02-11
Waterfox toolbar > Polly+ > Overview (+ button)
⚠ Codefile.io pages have been responding with error message 504: GATEWAY_TIMEOUT since at least March 30, 2024. Some of the important changes since then:
Polly+ settings
"facebook.com": ["polyfills/core-js.js"]"github.com": ["dom.webcomponents.enabled;true","compilers/Babel-Transformer.js","polyfills/AbortSignal.js","polyfills/core-js.js","polyfills/Crypto.randomUUID.js","polyfills/HTMLDialogElement.js","polyfills/HTMLFormElement.requestSubmit.js","polyfills/IntersectionObserver.js","polyfills/PerformanceObserver.js","polyfills/Webcomponents-pf_dom.js","polyfills/Webcomponents-pf_js.js","polyfills/ShadowRoot.js"]⚠ Commit pages with diff button require:
"google.com": ["image.webp.enabled;true"]"music.amazon.com": ["polyfills/Webcomponents-Bundle.js"]"music.amazon.com": "Mozilla/5.0 (%OS_SLICE% rv:78.0) Gecko/20100101 Firefox/78.0"
LeeBlnder
commented
1 year ago way cool, thank you @walmar !!
(I keep Intl.RelativeTimeFormat.js deactivated because I very much prefer the real timestamp over the roughly calculated span)
LeeBlnder
commented
1 year ago .. but: is there also a fix for the vanished cursor in GitHub's composer text fields (the one I just typed this text in)?
decembre
commented
1 year ago thank you @walmar: BIG thanks!
And as bonus, it seems solve my request too for, when i add Intl.RelativeTimeFormat.js : [Waterfox Classic] No Posted Time for Comments
Note: Where you find this updated version of Polly? Using Waterfox without it became difficult. It's like difficult to find the "official" place and more e decent documentation of it.
walmar
commented
1 year ago @LeeBlnder
is there also a fix for the vanished cursor in GitHub's composer text fields (the one I just typed this text in)?
I can't reproduce it.
@decembre
Where you find this updated version of Polly?
The unexpectedly appeared file of a Polly sub-variant seems to me that it has some kind of feelings and
decembre
commented
1 year ago "respects the privacy of the contributors who improve its development": Yes! :-)
LeeBinder
commented
1 year ago LOL, you made my day/month/year, @walmar , epic reply 🥇 . May you keep on grooving, coding and sharing
Squall-Leonhart
commented
1 year ago polly still causes crashes, better to go about it with a capability to enable webcomponents on a site by site basis.
robbely
commented
1 year ago on a site by site basis.
I thought that was what Polly's "Use request modification method for this domain" checkbox was for. When checked, the selected webcomponents are only used on specific sites.
Squall-Leonhart
commented
1 year ago as i mentioned, polly is still functionally unstable, and also slow as heck in some cases.
the component operates within the extension itself which is not exactly in an optimised state.
walmar
commented
1 year ago I updated my issuecomment-1362129403.
robbely
commented
1 year ago I updated my issuecomment-1362129403.
After this update, my account dropdown has changed from not showing anything (the bug fixed) to showing an error "Sorry, something went wrong."
walmar
commented
1 year ago I updated my issuecomment-1362129403.
After this update, my account dropdown has changed from not showing anything (the bug fixed) to showing an error "Sorry, something went wrong."
I cannot reproduce it if only the four options described in step three were checked.
robbely
commented
1 year ago Does anyone else have this issue or is it only on my system? I only have the four options selected. Other current issues which started recently - I can't attach files to a post, and clicking on the 3 dots top right of a post gives me a spinning circle with one option to "Quote Reply" underneath. I'll try and log in on another browser at some point to add screenshots.
walmar
commented
1 year ago I'll try and log in on another browser at some point to add screenshots.
Running Waterfox without interferencing extensions such as NoScript or Violentmonkey or even better with a fresh profile (where you don't even have to be logged in to reproduce some of the already clear visual issues) and the posting of the web console output seems to me more promising.
LeeBinder
commented
1 year ago Thank you @walmar.
@all: Polly checkmarks for GitHub:
-> Assets content opening up after clicking onto arrow:
NoScript and ViolentMonkey Extensions installed and enabled, too, but both inactive for GitHub.
LeeBlnder
commented
1 year ago Does anyone else have this issue or is it only on my system? I only have the four options selected. Other current issues which started recently - I can't attach files to a post, and clicking on the 3 dots top right of a post gives me a spinning circle with one option to "Quote Reply" underneath. I'll try and log in on another browser at some point to add screenshots.
@robbely :
robbely
commented
1 year ago @ALL: Polly checkmarks for GitHub:
Turning off polyfills/Webcomponents-Bundle.js fixed the menu issues. I notice now that walmar's post also has this turned off - it's a bit subtle.
I'm getting a different issue with attaching files now, at least there is an error this time "Something went really wrong, and we can’t process that file." Toggling ResizeObserver.js didn't help unfortunately.
Edit: after making changes in Polly, a new item popped up in noscript, enabling that fixes the upload attachment issue. Looks like it's all working again.
Many thanks @walmar + @LeeBlnder
walmar
commented
1 year ago @LeeBlnder
NoScript and ViolentMonkey Extensions installed and enabled, too, but both inactive for GitHub.
It is not my intention to imply that Polly conflicts with any other extension. Especially since I activated the extensions mentioned.
I just want to remind you that every type of code and setup can cause a personal unexpected behavior, even in relation to hardware, service account and network traffic. Therefore, it is always the best practice to rule out these options as much as possible before reporting and not just aiming at an object that is a waste of time for everyone.
I usually spend hours or days to reflect before I publish one of my comments to close the space for speculation of people with a tunnel view and a encroaching entitlement mentality. Due to many cases experienced with faster responses, in which people where selectively missing or overinterpreting sentence contents.
@robbely
Turning off polyfills/Webcomponents-Bundle.js fixed the menu issues. I notice now that walmar's post also has this turned off - it's a bit subtle.
@ALL: Polly checkmarks for GitHub:
I only have the four options selected.
I cannot reproduce it if only the four options described in step three were checked.
After this update, my account dropdown has changed from not showing anything (the bug fixed) to showing an error "Sorry, something went wrong."
The following steps seem to fix the latest loading issues with some GitHub page elements
- GitHub > Waterfox toolbar > Polly
- [ ] polyfills/Webcomponents-Bundle.js
You have already missed it twice! But yeah, whatever ...
LeeBinder
commented
1 year ago @walmar 100% agree. That's why when running into some issue, I always run profile manager and choose my "virgin" profile which I can purge with a click of a button, then test in there.
Also, don't give up; in these way-too-fast and superficial times people in general tend to overtake themselves. Unfortunately that has become the average Zeitgeist :(
robbely
commented
1 year ago You have already missed it twice! But yeah, whatever ...
Yes, apologies. I've got a lot going on at the moment but I should have paid more attention. Many thanks for your patience and for helping to keep Waterfox Classic alive.
EDIT
people with a tunnel view and a encroaching entitlement mentality
I think it is unfair to make "modern stereotype" judgements on people you have no knowledge of, or of their current circumstances.
Also in this case, it was still easy to interpret that the only changes for the user were extra checkmarks for the new bundle. The checkmarks and "uncheckmarks" in the updated post are pretty much invisible and I only noticed them for the first time in LeeBlnder's clearer image. Not a criticism, but an explanation of why I missed them.
Please carry on the good work, I know it probably gets stressful at times, but please also keep the controversy out of the thread.
ghost
commented
1 year ago @walmar I CAN'T USE ANILIST, it automatically crashes, can you help me? Also how do you guys decide to which polly flags do you need?
The-Solutor
commented
1 year ago For Github assets problem, as an alternative to polly you can use palefill, no configuration needed, just install and it works.
Squall-Leonhart
commented
1 year ago palefill doesn't work on waterfox.
The-Solutor
commented
1 year ago @Squall-Leonhart
I'm using it rightnow, and it works.
Is not like I posted a false info just to waste your time.
Squall-Leonhart
commented
1 year ago It doesn't work,
The-Solutor
commented
1 year ago Sure, and I'm an alien from an alternate reality
tordenflesk
commented
1 year ago Then you're lucky. Doesn't work for me either.
walmar
commented
6 months ago I updated my issuecomment-1362129403.
tordenflesk
commented
6 months ago I updated my issuecomment-1362129403.
Nice, athough there are still a few issues:
walmar
commented
5 months ago I updated my issuecomment-1362129403.
walmar
commented
4 months ago I updated my issuecomment-1362129403.
walmar
commented
2 months ago I updated my issuecomment-1362129403.
Squall-Leonhart
commented
2 months ago I updated my issuecomment-1362129403.
Shadowroot breaks the search widget on click, makes it appear in a narrow column on the right instead of dropiing down from the box.
pf_dom makes text appear in the search widget again, but pf_js appears to not do anything worthwhile
Youtube.com needs webcomponents enabled, i'd use the built in method rather tha the polyfill bundle simply because its faster
This updated polyfills+ does seem faster in general, and doesn't cause a parent process memory spike.
walmar
commented
2 months ago Codefile.io pages are working again for me.
⚠ Someone recommented "reddit.com": ["dom.webcomponents.enabled;true","image.webp.enabled;true"].
I tested this settings for https://www.reddit.com/r/waterfox/ with a fresh profile on Windows OS.
This caused the tab to crash and the system display resolution to change to a very low value. That's why I removed this dangerous line.
Shadowroot breaks the search widget on click, makes it appear in a narrow column on the right instead of dropiing down from the box.
You can replace .Overlay with action-menu .Overlay, dialog-helper .Overlay in the webextension/bg.js file to get the desired search box style as a logged in user.
I don't want to repackage for this small change.
Desktop (please complete the following information):
Describe the bug
a few days ago (maybe after updating to 2022.11, i am not sure) my waterfox classic 2022.11 started to have problems on github. with activated Polly file listings started to disapear after the page was fully loaded. the problem was not consistent for me, sometimes i got a listing which stayed but often it disappered.
javascript console got stuffed with some errors (see below). fork drop-down is empty. also sometimes the menu (code, issues, pull requests, ...) is not there. tried different settings for polly with no successs. after completly deactivating Polly the missing file listings where back but other problems approached.
anyone also have that problem? do i use the wrong Polly version or is waterfox classic now unusable even with Polly?