BrowserWorks / Waterfox-Classic

The Waterfox Classic repository, for legacy systems and customisation.
https://classic.waterfox.net
Mozilla Public License 2.0
176 stars 33 forks source link

Waterfox and ublock #66

Open Felipefpl opened 2 years ago

Felipefpl commented 2 years ago

Waterfox doesnt save the settings that are on top of the "Filter Lists" section of ublock 1.40.9 beta 11, if i check/uncheck any of the 4 settings once i close/open waterfox again the settings are reset to default.

I tested this against firefox 96, it works fine on it.

aeiouaeiouaeiouaeiouaeiouaeiou commented 2 years ago

Unfortunately for Classic due to lack of some WebExtensions APIs the last working version of addon is 1.32.4.

Killogy commented 2 years ago

@Felipefpl It works for me, unckecked 4 first options and some filters then restarted Waterfox and it was unckecked.

Checked 4 first options and filters, restarted Waterfox and these options it was checked.

Felipefpl commented 2 years ago

@Felipefpl It works for me, unckecked 4 first options and some filters then restarted Waterfox and it was unckecked.

Checked 4 first options and filters, restarted Waterfox and these options it was checked.

Killogy - strange, this doesnt happen here, i even made clean installations of waterfox/ublock to see if this fixed the issue but it didnt.

Felipefpl commented 2 years ago

I got a new problem: i have webcomponents/rootnode enabled in the settings to use github without problems and after i updated ublock to 1.41 i cant expand the messages of the commits when i click in the 3 dots. Tested on firefox 97 and it's all ok.

walmar commented 2 years ago

@Felipefpl, it seems to me that part of your reported behavior comes from changes mentioned in the release notes

Minimum supported browser versions has been bumped up:

  • Firefox 68

A new setting in "Filter lists" pane to control whether uBO should wait for all filter lists to be loaded before unsuspending network activity.

When I try to switch one of the options

then

  1. the message is logged in the Browser Console:

    ReferenceError: event is not defined 3p-filters.js:536:11

  2. the boxes are always displayed as checked after reloading the page
If this is the only new behavior caused by last bumped up minimum supported browser version, then this appears tolerable for me.

For the options

you have to pay attention to pressing the button: Apply changes

I got a new problem: i have webcomponents/rootnode enabled in the settings to use github without problems and after i updated ublock to 1.41 i cant expand the messages of the commits when i click in the 3 dots.

Not sure what you have enabled, but for me it expands with:

Waterfox-Classic/zakius@polly.xpi at classic · WaterfoxCo/Waterfox-Classic · GitHub >

@aeiouaeiouaeiouaeiouaeiouaeiou, you may have missed the workaround and suggestion.