BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.83k stars 340 forks source link

Enter key doesn't work in the address bar #1175

Closed swashdev closed 3 years ago

swashdev commented 5 years ago

Describe the bug When typing in the address bar, pressing the enter key does not begin navigation and does not initiate searches unless one of the search suggestions has been highlighted by the mouse cursor.

If no search suggestions have been produced by the program, nothing happens when the enter key is pressed. If a search suggestion is highlighted by the mouse cursor, whatever the user has typed in is then searched or a URL is navigated to, whichever applies according to normal operation. It doesn't appear to matter which suggestion is highlighted, as long as the cursor is inside the box which contains the search suggestions.

Expected behavior The enter key is meant to function as a shortcut for the "go" or "search" button on the address bar, even if no search suggestions have been provided.

Desktop (please complete the following information):

grahamperrin commented 5 years ago

If no search suggestions have been produced by the program, nothing happens when the enter key is pressed.

Not reproducible here with build 20190903144949 on Lubuntu.

A screen recording:

Can you reproduce the issue with Waterfox Classic in safe mode?

What's the build ID?

Is the issue reproducible with a new profile?

If we can make the issue reproducible, it might help to explain some of the following:

NebelNidas commented 5 years ago

Yeah, it seems to only happen very rarely. But I had this multiple times already, too. Unfortunately I couldn't test enough, since it was always on school PCs or others I had only short access to. Very strange, seems to be non-OS and software related, since in my cases it happened on multiple Windows 10 and 7 computers, some almost clean installed.

grahamperrin commented 5 years ago

Thanks, I sometimes found Return not working when expected but (to the best of recollection) never a problem in this situation:

If no search suggestions have been produced by the program, nothing happens when the enter key is pressed.

Three split-second frames from the (problem-free) screen recording:

2019-09-29 01:12:18 frame a

2019-09-29 01:12:18 frame b

2019-09-29 01:12:18 frame c

– that's the result of me typing enough nonsense for the application (or should I say, the installed search engine) to cease suggesting.

@swashdev before you key Enter:

What's your preferred search engine and if it wasn't integral to Waterfox, what was its origin?

swashdev commented 5 years ago

Restarting with add-ons disabled doesn't seem to help the problem. I can use the Enter key to visit a website from the start screen, but from then on the problem continues to present itself. I have found that pressing the Backspace key brings up the normal search suggestions and then the Enter key works, but then typing anything else causes the problem to come back again. It's almost like pressing Backspace causes the address bar to wake up and remember that I'm typing into it.

Edit: Typing a slash / also causes the address bar to "wake up" as described above. Weird.

The Build ID for my copy of Waterfox is 20190903144949; I got it from the Releases page on waterfox.net. The problem does not appear to present itself in a new profile.

My default search engine is Startpage. When I imported my Firefox settings into Waterfox, I got a warning that the plug-in wasn't compatible with my version of Waterfox, so I uninstalled it and then re-installed a new copy of the plug-in from the Startpage website.

Squall-Leonhart commented 5 years ago

I have sporadic reproduction in a profile, but not in others, all use the same settings and extensions.

Slater91 commented 4 years ago

The address bar stopped working with the latest update (2020.07.02) for me. The only solution I found is to remove the search bar, but this implies a loss of functionality. The issue is consistently present and persists across app and system reboots, and is also present in safe mode. No other app exhibits the issue, including Firefox. I am using KDE neon, based on Ubuntu 18.04.

hawkeye116477 commented 4 years ago

@Slater91 For me address bar works fine. Also just saying 2020.07.02 isn't sufficient, you mean Current or Classic?

Slater91 commented 4 years ago

Sorry, you are right! I forgot to mention that. It happens in Current, while Classic works fine. I just noticed that the address bar in Current stopped working again, adding back the search bar made it work. Please let me know if and how I can provide further info to understand where the issue stems from.

hawkeye116477 commented 4 years ago

Ok, I can reproduce now, seems it could be still same source of problem as on #1686 and #1683, regression from #1678. Apparently problem is somewhere on another place.

CC @MrAlex94

InvisibleManX commented 4 years ago

@Slater91 @hawkeye116477

Again, if a Home Page button is placed in front of the address bar, it gets magically fixed, just like the search problem was getting fixed by it in the preivous update -_-