search

BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.83k stars 340 forks source link

Some about:config settings need to be altered, but I can't seem to find them. #1427

Closed Peacock365 closed 3 years ago

Peacock365 commented 4 years ago

@MrAlex94 @laniakea64 @hawkeye116477

Some settings in about:config should be altered to different values, but I can't seem to find them. I ask you to create pull requests to fix those, if possible. The settings in question are:

Disable the predictive service (Necko): network.predictor.enabled - false https://wiki.mozilla.org/Privacy/Reviews/Necko

Squall-Leonhart commented 4 years ago

these prefs do not exist by default, so add them.

this isn't worth a bug.

Peacock365 commented 4 years ago

Where do I add them? In modules/libpref/init/all.js or in browser/app/profile/firefox.js or somewhere else? This is why I need help.

this isn't worth a bug.

Oh, come on. Bugs have been opened for less here. I need support and want to change some about:config values, i.e. implement a change, this is definitely worth a bug. And don't tell me what to do, I have contributed stuff already, contrary to you might I add.

Thanks for the non-support @Squall-Leonhart...

laniakea64 commented 4 years ago

Sorry @Peacock365 but I'm currently too hassled to do any pull requests in the foreseeable future :frowning_face:

Disable Microsoft Family Safety by default

https://github.com/MrAlex94/Waterfox/issues/538#issuecomment-568214398

If you use Windows to build and test your pull requests, you can try see if changing this does the job? - https://github.com/MrAlex94/Waterfox/blob/6bce12d08d55de605a41c66ea540108ec25418a8/security/manager/ssl/security-prefs.js#L50-L56

Peacock365 commented 4 years ago

Does the job. Thank you for pointing me to the location of the setting, @laniakea64! Took the opportunity and got rid of some SSL telemetry, as well (new PRs created.) Thumbs up!

Peacock365 commented 4 years ago

@hawkeye116477 @laniakea64 @MrAlex94

Any idea where the setting network.predictor.enabled can be found in WF Current?

hawkeye116477 commented 4 years ago

@Peacock365 You have searchbar on top, you can find :smile: Here it's: https://github.com/MrAlex94/Waterfox/blob/d8326e125b8fde7e73d44891df935504b12362b3/modules/libpref/init/StaticPrefList.h

reallyuniquename commented 4 years ago

@Peacock365 You really shouldn't patch browser internals just to change about:config options. Use about:config context menu and choose New or try autoconfig.