search

BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.82k stars 340 forks source link

Several cosmetic issues on G4. Please fix. #2279

Closed Peacock365 closed 2 years ago

Peacock365 commented 3 years ago

What happened?

Waterfox G4.0.0b1, macOS Big Sur 11.6

@adamp01 @MrAlex94

I found several cosmetic issues on G4 that need addressing before anything is released.

Minor nitpicks / wishes:

Thank you for your attention.

Reproducible?

Version

G4.𝑋 (Future)

What platform are you seeing the problem on?

macOS

Relevant log output

No response

adamp01 commented 3 years ago

Thanks @Peacock365 - I'll be sorting out all the about:preferences related stuff today.

Peacock365 commented 3 years ago

@adamp01

Thanks for the quick reply the loudness indicator graphical issue especially drives me mad though.

adamp01 commented 3 years ago

@Peacock365

Would you be able to highlight what you are seeing vs. what you expect please? I was quickly comparing G3 with G4 and couldn't spot a difference - if you have some screenshots that'll help me pick up on what I'm missing

Peacock365 commented 3 years ago

@adamp01

  1. Set Waterfox Lepton as your theme.
  2. Go to any YouTube video.
  3. Look at the tab the video plays in.
  4. Success.
Peacock365 commented 3 years ago

@adamp01

To be clear, when the Waterfox Lepton theme is used, is the loudness indicator meant to sit at the top right of the tab's favicon when a video plays within that tab? Because it sure as hell looks broken.

adamp01 commented 3 years ago

@Peacock365

This is the intention of the theme creator, yes. The reason for this is due to Mozilla updating where the Mute Tab overlay is rendered, thus making it impossible to do much with just css. If you take a look here: https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser-tab.js#23 The tab-icon-overlay is the class that the Mute Tab overlay falls into. It would be possible to amend this and move that line down to just above the tab-close-button on line 39, but that would break the Proton theme for users who prefer that (and probably give us some merge conflicts when pulling from Firefox at some point). Whilst I do agree the overlap of the overlay and the favicon isn't the most appealing of things, I think it is still preferable to how Proton handles things: imageimage Vs. Lepton:

image
Peacock365 commented 3 years ago

@adamp01

So, in effect, this is not a bug, but a feature? No offense, but that looks horrible. Really, it does. Two possible fixes:

OR

The way it looks now, it seems like a bug. Again, no offense, I like the rest of the theme as it is.

adamp01 commented 3 years ago

@Peacock365

I might add in an option to change how it looks at some point, but it's not at the top of the priority list right now.

Peacock365 commented 3 years ago

@adamp01

I have found several other issues as well, in addition to the ones already mentioned:

adamp01 commented 3 years ago

@Peacock365

Thanks for all this - I'll action all of these.

adamp01 commented 3 years ago

So this thread is up to date:

Tracking protection should be resolved with this: https://github.com/WaterfoxCo/Waterfox/commit/cd8b58d31eb673674be27b4bc82b6d72056eda92 Signature required issue should be resolved with this: https://github.com/WaterfoxCo/Waterfox/commit/fdb9a7ebc7b7dc459634e098f33acf128bbff3c8 Chrome web store issue should be resolved with this: https://github.com/WaterfoxCo/Waterfox/pull/2305

MrAlex94 commented 3 years ago

https://github.com/WaterfoxCo/Waterfox/commit/6391c21385e5ad6982dd1231ed64191342a84164

This should be the last of the issues resolved.

I'll close this unless you think there's anything unresolved.

Peacock365 commented 3 years ago

Here is another few issues I have found, but not sure if they are bugs (as of Waterfox G4.0.0b2):

https://chrome.google.com/webstore/detail/metamask/nkbihfbeogaeaoehlefnkodbefgpgknn

https://addons.opera.com/en/extensions/details/ublock/

Now, I am not sure whether or not Waterfox is genuinely missing certain APIs or if these extensions just don't recognize existing APIs. So not sure if this is a bug or not.

@MrAlex94, please reopen the issue for the time being. Thank you.

adamp01 commented 3 years ago

@Peacock365 I'll get back on the about:preferences stuff and fix it in the React code instead, that should solve those issues. Thanks for pointing out the other missing settings as well. I'll also take a look at the telemetry stuff with some urgency.

The rest I'll make a note of but will just go into general prioritisation.

Peacock365 commented 3 years ago

To be honest, all the things I mentioned are probably high priority. If they were not, I would not have mentioned them specifically. Good to hear that at least some of them will be fixed ASAP.

MrAlex94 commented 3 years ago

For some extensions in the Chrome Web Store and Opera Store, when you try to add them, the following text appears: "This add-on could not be installed because not all of its features are supported". Here are two examples

That's because Firefox doesn't support every WebExtension API.

Waterfox still connects to firefox.settings.services.mozilla.com all the time... Are you sure that there is no way to fix this at the code level?

Yes, even Tor still keeps these connections.

Please don't forget the scheduled telemetry task on Windows, please disable at build level: https://www.ghacks.net/2020/04/09/mozilla-installs-scheduled-telemetry-task-on-windows-with-firefox-75/

This is already disabled.

Peacock365 commented 3 years ago

That's because Firefox doesn't support every WebExtension API.

Are you sure about that? I am even getting this for extensions that I was able to add to Waterfox G3. And the overall number of extensions for which this message appears is very high, too.

Yes, even Tor still keeps these connections.

Was there any specific reason why or were they just not able to remove it? Genuinely curious here.

This is already disabled.

Ah, OK. Thanks. I've edited my comment above as well to reflect this.

Peacock365 commented 3 years ago

@MrAlex94

Is this a potential fix for firefox.settings.services.mozilla.com ?

https://wiki.archlinux.org/title/Firefox/Privacy#Editing_the_contents_of_omni.ja

MrAlex94 commented 3 years ago

Are you sure about that? I am even getting this for extensions that I was able to add to Waterfox G3. And the overall number of extensions for which this message appears is very high, too.

Yes I'm sure. If you have examples of ones that work on G3 and don't on G4, let us know.

Was there any specific reason why or were they just not able to remove it? Genuinely curious here. Is this a potential fix for firefox.settings.services.mozilla.com ?

What that guide suggests is a terrible idea. The browser will output a bunch of noise complaining about lack of connections and it does break things when it can't access those JSON dumps. It's used for everything from HSTS pinning to addon blocklists.

Peacock365 commented 3 years ago

What that guide suggests is a terrible idea. The browser will output a bunch of noise complaining about lack of connections and it does break things when it can't access those JSON dumps. It's used for everything from HSTS pinning to addon blocklists.

OK, fine. I relent. There seem to be good reasons for why this connection was kept then.

black7375 commented 3 years ago

Hello? I am the author of Lepton Theme.

I came across it by chance while doing a search. I'm happy to be able to make a small contribution from a fork as old as Waterfox.

Whilst I do agree the overlap of the overlay and the favicon isn't the most appealing of things, I think it is still preferable to how Proton handles things:

Let me explain the intent when determining the overlay location. In the case of the general tab, I was thinking of placing it right behind the favicon like Edge. However, it has the current design for the following reasons.

And here's why I removed the label.

The sound icon in the screenshot should be raised by about 3.5px to cover less of the favicon. It worked correctly in 1.0.0, but I think there was a mistake in the recent version while refactoring. Fortunately, a bug report has arrived and has been fixed in the latest version released recently. https://github.com/black7375/Firefox-UI-Fix/releases/tag/v4.2.2

Why aren't Lepton Light and Lepton Dark specifically selectable? Why only according to the system theme?

I'm making it, but the lepton is pretty complex. Looking inside, it is divided into the following modes:

Therefore, it may take some time to provide the theme. Anyway, it would be cool if you could see system default, light and dark mode. If waterfox maintainer or developers ever need my help, I can give you some advice.

I'm very excited to meet my project at Waterfox, thank you again.

MrAlex94 commented 2 years ago

@black7375, thank you for the informative post! It is a great theme which is why it has been set as default 👍

Why aren't Lepton Light and Lepton Dark specifically selectable? Why only according to the system theme?

This is more related to Waterfox - and will be coming in a future update.

If we can help in any way with the themeing do let us know!

Peacock365 commented 2 years ago

Additional issues I have found:

Peacock365 commented 2 years ago

@adamp01

Please react to my prior comment, the previous two issues still persist as of Waterfox G4.0.3.1

Additionally, I have found the following issues:

adamp01 commented 2 years ago

@Peacock365

Peacock365 commented 2 years ago

@adamp01

I just wanted to ask: What is the status of add-on version number restoration in about:addons? Seeing the current version number would be handy since it makes updates more visible and may help when resolving add-on issues here. It seems like a trivial(?) fix to add this back, please make this a priority.

I have found two further issues (Waterfox G4.0.8):

Further wish list:

adamp01 commented 2 years ago

@Peacock365 - I'll look into the addon version number today.

Thanks for raising those issues with the addon store compatability piece, I'll take a look at this as well.

We haven't had as much capacity as we had hoped for so this hasn't been getting as much attention as it needs, as such we don't have the time currently to look into expanding to Edge. Our priority would be introducing compatability for externally_connectable to improve the amounts of addons compatible with Waterfox.

adamp01 commented 2 years ago

@Peacock365 - For the addon version number, it is displayed on the card detail like below:

image

That should be sufficient no? Or are there cases you have seen where this is not being displayed?

Peacock365 commented 2 years ago

@adamp01

No, I mean the add-on version number in the add-on list, directly in about:addons (list view of all extensions). Waterfox Classic had it, Waterfox G3 had it, Waterfox G4 doesn't. You patched it back in in Waterfox G3 as well I recall. Having the add-on version number directly in the list view is better than what we have now because 1) updates are immediately visible from the list view, no need to click through all extensions to see if and when anything has been updated and 2) it makes troubleshooting easier because users are more likely to post the version number of the add-on if it is outright displayed in the list view. I mean, minimalism has its benefits, but Mozilla has been taking it a step too far here, please patch the add-on version number in the list view of all add-ons back in. Should not be hard to do. You also list this as an unresolved issue on your website btw:

https://www.waterfox.net/docs/releases/G4.0.8

I have found one further issue:

adamp01 commented 2 years ago

@Peacock365 - gotcha, I'm PR'ing something to make it look like this:

image

I'll speak to Alex about flipping network.captive-portal-service.enabled as well.

Also, I did take a look at the addon stores stuff yesterday and I've noticed that sometimes the content handler picks up the x-chrome-extension type and attempts to install the addon correctly, and other times (seemingly at random) it won't and attempts to download it. Might take a minute to figure out what the root cause is here, as profiling was rather unhelpful.

I also didn't notice any rendering issues on the Opera web store, could you give me some additional details around what you are seeing?

Peacock365 commented 2 years ago

@adamp01

Thanks for fixing / investigating all mentioned issues here. Well done.

Opera Store issue: There is an "Add to Waterfox" green button at the top right of every extension page, e.g. here: https://addons.opera.com/extensions/details/ublock/ This button is enlarged / being rendered wrongly here. Can you confirm this?

adamp01 commented 2 years ago

Looks like this for me, which is how it was intended:

image
Peacock365 commented 2 years ago

@adamp01

Ah OK, the "Add to Waterfox" green button is much more enlarged for me. Since you can't reproduce the issue (I agree, your picture is as it should look), then I guess it is an issue with my profile. So consider this issue RESOLVED.

Peacock365 commented 2 years ago

@adamp01

Next to the network.captive-portal-service.enabled issue, I noticed that we still do not have feature parity with Waterfox G3. Waterfox G3 supported NPAPI plug-ins, this support is gone aside from the bundled ones. Can you somehow make Waterfox detect plug-ins like Adobe Flash again? Is that a trivial fix?

Peacock365 commented 2 years ago

@adamp01

Is there any possibility of an NPAPI fix? Would be great if that were possible, but I have no idea how trivial or non-trivial that would be. I've seen that you have fixed the Chrome Web Store issue, thanks for this!

adamp01 commented 2 years ago

@Peacock365 - I'll chat with Alex and try to gauge how hard the NPAPI piece would be.

I appreciate you consistently raising things you find here as it's led to quite a few improvements and fixes, so wanted to quickly say thanks for that. If i miss anything as well let me know.

s8wc3 commented 2 years ago

As of version 4.0.8 when using the Lepton theme the titlebar is painted in grey and doesn't respect the system's titlebar colour. Windows 7 shown for effect (looks the worst), issue persists regardless of Windows version. OK: 2022-03-29_02-25-13 Scuffed: 2022-03-29_02-25-46 @black3735 is this a known issue with the lepton theme?

black7375 commented 2 years ago

I'll test it tomorrow.

black7375 commented 2 years ago

image

https://www.waterfox.net/docs/releases/G4.0.8

It will be one of two effect.

✨ New

✔ Fixed

The system theme is applied only when :root:not(:-moz-lwtheme), and it seems that the light weight theme is forcibly specified.

Peacock365 commented 2 years ago

@MrAlex94 @adamp01

As of Waterfox G5.0b2, I have found three issues:

Please fix these issues before pushing out the final build. Thank you.

Peacock365 commented 2 years ago

@MrAlex94 @adamp01

The issues still persist as of Waterfox G5.0b4, and so does the connectivity issue with public WiFi hotspots due to how you set network.captive-portal-service.enabled, please respond if you have noticed this new bug report.

adamp01 commented 2 years ago

Thanks @Peacock365 - I have seen this and will be doing some PRs to achieve parity.

adamp01 commented 2 years ago

I have done a PR to remove the greyed out options in about:preferences#general.

For DoH add-on, this is actually just left in to reduce headaches from merge conflicts when we pull from upstream. The addon itself is a basically blank manifest and doesn't do anything as here: https://github.com/WaterfoxCo/Waterfox/blob/future/browser/extensions/doh-rollout/manifest.json

Will check over prefs again, but I believe all the relevant ones have been captured, they are not all in the commit that you linked to.

Peacock365 commented 2 years ago

@adamp01

I see what you say about the DoH system add-on, understood.

Will check over prefs again, but I believe all the relevant ones have been captured, they are not all in the commit that you linked to.

Unfortunately, you are still missing the following prefs (all locked):

browser.urlbar.speculativeConnect.enabled to false

_browser.xul.error_pages.expert_badcert to true

extensions.experiments.enabled to true

Enabling pref sync was a good idea; I would also suggest the following sync prefs changed, this is all the nonsense left I think:

services.sync.prefs.sync.browser.newtabpage.activity-stream.section.highlights.includePocket to false

services.sync.prefs.sync.browser.newtabpage.activity-stream.asrouter.userprefs.cfr.addons to false

services.sync.prefs.sync.browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features to false

services.sync.prefs.sync.browser.newtabpage.activity-stream.feeds.section.topstories to false

services.sync.prefs.sync.browser.discovery.enabled to false

services.sync.prefs.sync.browser.crashReports.unsubmittedCheck.autoSubmit2 to false

services.sync.prefs.sync.app.shield.optoutstudies.enabled to false

services.sync.prefs.sync.browser.newtabpage.activity-stream.section.topstories.rows to false

I also suggest enabling the search bar by default (not locked):

browser.search.widget.inNavBar to true

And yeah, there is still the network.captive-portal-service.enabled that has not been tackled for ages now and causes the browser to behave in unexpected ways when connected to a public WiFi.

Last but not least, I am missing the Proton default theme of Firefox, why do you consider Lepton the one and only now? I think this should be up to the user to decide. The Australis themes are also missing, however I always considered them to be subpar; here is perhaps a better approach you could look at: https://github.com/wilfredwee/photon-australis

Peacock365 commented 2 years ago

@adamp01 @MrAlex94

Adam, have you noticed my recent post? Please reply if you have noticed.

I slowly begin to be frustrated by Waterfox, more specifically its major releases. There always seem to be regressions that have already been patched in earlier Waterfox versions, and a lack of feature and settings parity. The way you reapply patches over and over again yet missing stuff every single time is highly frustrating, no idea how LibreWolf does it but they seem to be way more consistent across releases (and they actually rebase on major Firefox releases quite frequently). Whatever you do there is chaotic and desperately needs streamlining @Waterfox devs.

There is also a lack of focus on privacy (like newer Waterfox releases allowing various forms of prefetching for example) and an increasingly arrogant attitude of the developers, like taking away the ability of editing 000-waterfox.js (the Waterfox-specific preferences) from other contributors. No idea what practical purpose this even serves, as contributors can't directly patch the source code without approval anyway, so why aren't you open to suggestions? I don't get it. Anyway, if you think you need to manage this on your own, which is in principle fine by me, then at least you should be more responsive to requests like the request I made here just before this comment.

You also ignore longstanding issues like Waterfox acting up when connected to public WiFi hotspots in spite of me having brought this up numerous times(!) over the course of months(!), as if it's the intended behavior. Wow, I mean, if you give up on a more "hands on" development approach with greater community involvement, you better make sure to be more responsive to bug reports at least, otherwise this shows that you can NOT handle it without more direct community involvement.

I am frustrated with this software but more so the development process, I think I will throw my support behind LibreWolf in the future, their developers seem more sensible to me and follow more streamlined development processes. Highly annoyed by the ongoings here!

You can now hide or downvote or delete my post or whatever, I just feel like this needed to be said. I am pretty much done here if nothing changes for the better.

adamp01 commented 2 years ago

Hey @Peacock365 - Apologies for the slow response, I've been doing a lot of infra work and haven't been actively monitoring things as much as I should.

I've done a PR to cover the additional preferences you mentioned above. We did unlock the captive portal pref for G5, but don't believe it should be true by default.

For Proton, you can set userChrome.theme.enable to false. This is a preference that we are still in the process of adding to about:preferences but that will be coming shortly.

The main reason that major releases have been challenging is related to the amount of updates that had historically been made to Mozilla controlled source code, so doing a huge rebase onto a new major branch had conflicts galore. We have been putting a lot of work in to untangling this, something that we have almost finished.

Why do you say that we have taken away the ability of editing 000-waterfox.js from contributors? Is this related to locking prefs or something else?

I, personally, have greatly appreciated your input since I've been working on the browser and apologise that delays in response and action have removed any desire for you to continue this. I wish I could say with certainty that moving forward everything (specifically major releases) will be far more efficient, but we are always at the mercy of Mozilla to some extent.