BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.74k stars 334 forks source link

Waterfox G4 v4.1.0 (latest) - Open Link in New Tab missing + cookies and auto-signing into sites problems #2657

Closed Objectivite closed 2 years ago

Objectivite commented 2 years ago

What happened?

Open Link in New Tab when right-clicking on a link, is now missing (was ever present until 4.0.8)

image

Also, going to websites like www.theguardian.com keeps asking to agree for Cookies, and a number of sites, including The Guardian, do not auto-sign in as they used to, I have to keep clicking the LOGIN button on those sites to be logged in. This did not happen in 4.0.8.

O.

Reproducible?

Version

G4

What platform are you seeing the problem on?

Windows

Relevant log output

No response

MrAlex94 commented 2 years ago

Thanks for the report. I can reproduce this issue when choosing a non-default theme on Windows 11. Will try and get a fix out ASAP.

Can I just confirm your version of Windows?

Edit #1: @Objectivite It actually looks like I can't reproduce this, I misread the right click context menu. Here's what it looks like on Firefox Dynamic theme, Windows 11 with G4.1.0.

Plain text domain:

image

Link:

image

Do you have the same issue on both plain text domains and links? Can you consistently reproduce on a certain web page?

Objectivite commented 2 years ago

Thank You.

O.

MrAlex94 commented 2 years ago

Thank You.

O.

I've made an edit to the reply above.

Objectivite commented 2 years ago

Just testing - do not reply to this

https://www.cnn.com

https://github.com/WaterfoxCo/Waterfox/issues/2657

O.

Objectivite commented 2 years ago

OK - this is very interesting, and much more specific than I thought originally.

It works normally on a link that is highlighted as a link.

However, when I noticed it I was in the comments section of an article in the Guardian newspaper. A user had put a link to a page on the Independent and in The Guardian comments page links are not clickable BUT if you highlight the whole link and right-click, Waterfox recognises that it is a link and gives you the menu. In 4.0.8 that menu includes Open in New Tab, but it does not in 4.1.0 (I verified that).

So it is a very very specific instance - in all other instances I do get the "Open in New Tab" on the right-click.

You can access the Guardian comment in question at this link -

https://www.theguardian.com/commentisfree/2022/apr/06/bucha-ukrainians-russian-military-donbas#comment-155775557

O.

MrAlex94 commented 2 years ago

It's a very odd one, shows fine for me:

image

If you open up the browser console, do you see any error messages that might look relevant? I'd recommend right clicking a few times so any error message stands out.

Objectivite commented 2 years ago

Hi Alex,

What a strange one.

I went back to that comment, repeated the process and I had the same problem. Then, noticing that the top of the popup was right up the top edge of my screen I thought "I wonder if it is because I have the comment too far up the page and the popup is not able to fully develop". So I scrolled the page down a little bit to ensure that that Guardian comment was just below halfway, right-clicked and "Hey Presto" I now have the correct popup and Open Link in New Tab is showing.

Where it gets strange is that I then scrolled the page back up so that Guardian comment is near the top of the page and ..... it still works fine !

Without closing Waterfox I then opened a new tab, searched for that comment again, left it positioned near the top, right-clicked and ..... it still works.

Conclusion : after all these tests and given how hard it was for me to reproduce after the first instance I do not think you should waste any more time on this. If it happens again I will scroll down a little and it will work.

I am happy for you to close this incident. I'll monitor the cookies issue (second part of the incident) - if I still have problems I'll open a new case.

O.