userChrome broken in G5

[K4sum1]

What happened?

Because of the modified theme, userChrome.css is kinda broken.

Reproducible?

• [X] I have tested this on Firefox.

Version

Other

What platform are you seeing the problem on?

Windows

Relevant log output

No response

[MrAlex94]

Thanks - will try and detect if a custom userChrome is being set and unregister the default userChromes when that happens.

As a quick workaround, could you try installing a random theme such as: https://addons.mozilla.org/en-US/firefox/addon/pure-neutral/?

[K4sum1]

As a quick workaround, could you try installing a random theme such as: https://addons.mozilla.org/en-US/firefox/addon/pure-neutral/?

It kinda works but not really, it's still bugged like that.

[starfan101]

dose anyone have a link too the g5 so i can test it

[troysjanda]

Should add back the original Firefox default themes. Let the user decide the theme they would like to use.

[MrAlex94]

As a quick workaround, could you try installing a random theme such as: https://addons.mozilla.org/en-US/firefox/addon/pure-neutral/?

It kinda works but not really, it's still bugged like that.

Hmm, might be something else then. Do your customisations work on ESR102?

[thunderstone135]

@MrAlex94: I noticed that you updated Lepton. The reason the theme is no longer working is due to the CSS code being placed in userChrome.css inside omni.ja. The CSS code should be placed in leptonChrome.css and just mentioned in userChrome.css using this line:

@import url("css/leptonChrome.css");

Additionally, the updated Lepton is now using user.js.

[K4sum1]

As a quick workaround, could you try installing a random theme such as: https://addons.mozilla.org/en-US/firefox/addon/pure-neutral/?

It kinda works but not really, it's still bugged like that.

Hmm, might be something else then. Do your customisations work on ESR102?

I don't need to test ESR102, they worked fine on Firefox 101, 102, and 103. ESR shouldn't be any different.

[Keefaetana]

@MrAlex94: I noticed that you updated Lepton. The reason the theme is no longer working is due to the CSS code being placed in userChrome.css inside omni.ja. The CSS code should be placed in leptonChrome.css and just mentioned in userChrome.css using this line:

@import url("css/leptonChrome.css");

Additionally, the updated Lepton is now using user.js.

Perhaps something about this is why Tab Mix Plus can't do multi-row tabs anymore, too?

[thunderstone135]

Perhaps something about this is why Tab Mix Plus can't do multi-row tabs anymore, too?

I'm not sure since I'm not using the Multi-row tabs feature of Tab Mix Plus. You have to ask @onemen or @black7375 about it.

[black7375]

Is Waterfox G5 using Lepton v5.0.0 or higher? All options are activated using configs, and nothing changes without options.

---

The reason for conflicting with TabMixPlus is because of !important in userChromeCSS. In userChromeCSS, it does not work without !important due to css loading order.

[onemen]

Try to change the theme, currently Tab Mix Plus multi-row work only with modern theme.

Anyone that is willing to help me make Tab Mix Plus work with all Waterfox theme please post a PR here

[MrAlex94]

I've added a pref, userChrome.theme.enable, which can be toggled to false to disable the Lepton customisations.

This will be in Beta 2 - so hopefully people can try and see if it stops conflicting with their specific customisations.

[troysjanda]

Awesome Alex thanks for listening as always. Also for the hard work.

On Mon, Sep 5, 2022, 9:45 AM Alex Kontos @.***> wrote:

I've added a pref, userChrome.theme.enabled, which can be toggled to false to disable the Lepton customisations.

This will be in Beta 2 - so hopefully people can try and see if it stops conflicting with their specific customisations.

— Reply to this email directly, view it on GitHub https://github.com/WaterfoxCo/Waterfox/issues/2780#issuecomment-1237297285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF336MJAED56T54EPFBYGADV4YPT3ANCNFSM562KYN3Q . You are receiving this because you commented.Message ID: @.***>

[thunderstone135]

@MrAlex94 You actually don't need to disable the Lepton theme. You just need to place userChrome.css inside the css folder, then rename it to leptonChrome.css. After that, create a new userChrome.css file and type @import url("css/leptonChrome.css");, then place it outside the css folder. For userContent.css, just repeat the same steps.

If you want a much easier step, just download the latest Lepton release here and just copy these items:

• css folder (which contains leptonChrome.css and leptonContent.css)
• userChrome.css
• userContent.css
• user.js

P.S. For user.js, you just need to copy the prefs and integrate it with Waterfox (at least the default ones, the non-default ones have // or /* */ on them).

[K4sum1]

Works for me, but I'd like to see others have success before closing.

[MrAlex94]

@onemen,

We've now reworked the way our custom CSS is loaded in 864a21038e369ce0b3f61ea7a6ae660ee4c5c577.

Some API notes:

   * A user sheet loaded via this API will come before userContent.css and
   * userChrome.css in the cascade (so the rules in it will have lower
   * precedence than rules in those sheets).

I'm hoping this means that TabMixPlus will work without having to disable Lepton.

[onemen]

@MrAlex94,

So far with G5, Multi-row tabs does not work properly

Changing userChrome.theme.enable to false seems to fix this issue.

How do i need to load Tab Mix Plus style-sheets in order to avoid this issue. keep in mind that the solution need to be compatible with Firefox.

[onemen]

@MrAlex94,

The issue is in the file userChrome.css:

/** Tab UI ****************************************************************/
/*= Tab - Connect to window ==============================================*/
@supports -moz-bool-pref("userChrome.tab.connect_to_window") {
...
  #TabsToolbar {
    overflow: hidden;
    /* Prevent toolbar area over */
  }
...
}

The rule overflow: hidden caused the issue, I can fix it by adding this to Tab Mix Plus styles

#TabsToolbar[multibar] {
  overflow: unset !important;
}

[black7375]

Lepton is planning to add feature related to multirow.

• https://github.com/black7375/Firefox-UI-Fix/commits/dev
• https://github.com/black7375/Firefox-UI-Fix/issues/315