When you open more than 13 tabs the userChrome.css to remove tab close button no longer works

skooter7 commented 1 year ago

What happened?

This happened after I updated to Waterfox 5. Both this

#tabbrowser-tabs .tabbrowser-tab .tab-close-button {display:none!important}

#tabbrowser-tabs ~ #alltabs-button {display:none!important;}

and this

.tabbrowser-tab .tab-close-button {visibility: collapse !important;}

no longer work after you open more than 13 tabs. To be more specific as long as you have 13 tabs the css works and the close tab button doesn't appear at all, more than that and it appears when you hover over the tab with the mouse.

This issue does NOT happen on firefox (the question below btw is weird, yes I have tested on firefox but it's not reproducible, do I click it or not?)

Btw I assume this is some kind of graphical error and the number of tabs needed for this to happen might not be consistent and depends of resolution among other things. My resolution is 1080p. Also tried to move the tab bar in other positions but the bug persists so it's not that.

Reproducible?

[ ] I have tested this on Firefox.

Version

Other

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Balzhur commented 1 year ago

Cannot confirm. This works for me in G5 and userChrome.theme.enable = false

/* GPL-3.9 Copyright (C) 2007 Timvde/UserChrome-Tweaks; Code pulled from https://github.com/Timvde/UserChrome-Tweaks
 * Only show close buttons on background tabs when hovering with the mouse
 * Contributor(s): Timvde */
#TabsToolbar #tabbrowser-tabs .tabbrowser-tab:not([selected]):not([pinned]) .tab-close-button {
    visibility: collapse !important;
    display: none !important;
}

#TabsToolbar #tabbrowser-tabs .tabbrowser-tab:not([selected]):not([pinned]):hover .tab-close-button {
    visibility: visible !important;
    display: -moz-box !important;
}

skooter7 commented 1 year ago

and userChrome.theme.enable = false

Yeap, that's it, the problem is fixed. Looks like the theme was partly overriding the css or something? Is this some kind of bug with the theme?

BrowserWorks / Waterfox