BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.74k stars 334 forks source link

WF automatically updated even though I set it not to #3423

Open thekcool opened 4 months ago

thekcool commented 4 months ago

What happened?

WF just auto updated even though I have it set to "Check for updates but let you choose to install them".

Just installed a clean G6.0.12 a few days ago.

Running Win10 Pro 22H2 19045.4355

I installed a clean G6 because this was an issue since I upgraded from G5 to G6 also because there would be 2 WF entries in my Windows app/programs list after every upgrade (this has been an issue since I upgraded to G5). Initially I turned off updates and subscribed to github releases to get notified of updates and manually downloaded and installed them. After uninstalling WF and deleting all traces (including registry) I installed a clean G6.0.12. Again WF automatically updated without my permission. Also my apps list shows WF as G6.0.12 while the browser itself shows G6.0.13 however only 1 WF is listed. Screenshot 2024-04-26 083656

Reproducible?

Version

G6

What platform are you seeing the problem on?

Windows

Relevant log output

No response

allanonmage commented 4 months ago

I have run into this problem recently, and in a multitude of different ways. That tells me there are multiple points in the code that do updates independently and not properly checking the setting. Most likely, this is some upstream shenanigans from Mozilla, or possibly the sabotage I've heard that Google does against Firefox. Or Waterfox kept the UI but the back end functionality changed and Waterfox didn't keep up.

It seems there are some non-browser updates that get pushed, regardless of update setting. Somehow new extensions are getting half installed without user knowledge or consent, and since they are causing problems, they are being found. Sidebar is what I've come across, which causes a huge memory leak, sucking up all system RAM, which then makes things run weird until you reboot. Since it's an extension, if you kill the process (in details, not processes), all of your other extensions will die too. There are instructions online to turn it off.

One of my machines that had the setting set to "Never check for updates" now has an update pending. g6.0.11 64 bit on Windows.

Even if you select "check for updates but let you choose to install them", the updates are still downloaded and will be silently installed when you reboot Waterfox.