BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.57k stars 327 forks source link

(Auto-) Update via browser doesn't work #3450

Open Striker243 opened 1 month ago

Striker243 commented 1 month ago

What happened?

Problem description: The update function of the browser doesn't work as intended. I have the browser set to "Check for updates but let you choose to install them" and this works fine till a new update is found. Then I get notified and get send to the download page for the manual update without the possibility to directly update inside the browser (see attached picture). I can set it to "Automatically install updates" but after pressing F5 to reload it resets back to "Check for updates..". The problem has existed for a long time but I always thought it is a general bug but when I recently looked through reddit and Github I noticed there were no related reports and started a search on my system.

Expected behaviour: When getting notified about a new update, it should be possible to click "Update to G###" without needing to download the installer, closing the program and updating manually.

Conducted tests with version G6.0.12 & G.6.0.13:

Then I copied the profile folder into a Win10 VM and tested there:

I hope my description is comprehensible and someone finds out where the update process fails. Thanks in advance :) About Waterfox

Waterfox Settings Update

Reproducible?

Version

G6

What platform are you seeing the problem on?

Windows

Relevant log output

<?xml version="1.0"?><updates xmlns="http://www.mozilla.org/2005/app-update"><update xmlns="http://www.mozilla.org/2005/app-update" appVersion="115.11.0" buildID="20240424110000" channel="release" detailsURL="https://www.waterfox.net/docs/releases/G6.0.13" displayVersion="G6.0.13" installDate="1714309303893" isCompleteUpdate="true" name="Waterfox G6.0.13" previousAppVersion="115.11.0" promptWaitTime="3600" serviceURL="https://aus1.waterfox.net/update/Waterfox/G6.0.12/WINNT_x86_64/release/Windows_NT%2010.0.0.0.19045.3324%20(x64)/ISET:SSE4_2,MEM:8092/default/default/update.xml?force=1" type="major" statusText="Install Failed" foregroundDownload="true"><patch size="73240877" type="complete" URL="https://cdn1.waterfox.net/waterfox/releases/G6.0.13/update/WINNT_x86_64/waterfox-G6.0.13.complete.mar" errorCode="91" finalURL="https://cdn1.waterfox.net/waterfox/releases/G6.0.13/update/WINNT_x86_64/waterfox-G6.0.13.complete.mar" selected="true" state="failed" hashFunction="SHA512" hashValue="38ab0ebffa2318da8312f21522ea70bb8da3f13103ce48e9e77246ab2deed540842811e17da393b2bccc10f04ab5d150049324203577d88ca32b9a8bb15f0a37" internalResult="0"/></update></updates>
Fritz66 commented 4 weeks ago

I wanted to add that this happens to me as well. I'm using Linux and Waterfox G6.0.14, and there actually is no update available. Here is a short video that shows what happens when I try to update the browser: https://files.catbox.moe/vq046n.mp4

But the same thing happens when an update is actually available. I would expect it to work the same way as it does with the Tor browser, Mozilla browser, and Firefox ESR, and just download and install the update without opening the download page.

Since I'm not the only one experiencing this, I assume it's a bug.