search

BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.9k stars 343 forks source link

Restart Button Missing #3595

Open slumbergod opened 3 weeks ago

slumbergod commented 3 weeks ago

What happened?

I just upgraded to Waterfox 6.5.0 in Manjaro Linux. I was tweaking some css customisations but when I went to restart waterfox from the main menu I noticed there is no restart option, only quit. In my preferences I have it enabled and I have disabled and reenabled it several times and restarted the browser between changes but I cannot get the restart option back.

Is anyone else experiencing this? Had the option moved location from main menu?

Reproducible?

Version

Other

What platform are you seeing the problem on?

Linux

Relevant log output

No response

reticulatus commented 3 weeks ago

On Mint 22, I also have no restart button, although the option is set in preferences.

aermak commented 3 weeks ago

On win11 and missing that restart button as well.

Bonza13 commented 3 weeks ago

Turn on\off in settings doesn't work.

NotesTracker commented 3 weeks ago

Same problem with Windows 10,

Reverted to older G6.0.20 version and will await fix. This also fixed separate annoying issue in 6.5.0 where the bottom part of all tabs in the tab bar were being truncated (tab height issue).

Splitwirez commented 3 weeks ago

Same here - thought I was going crazy, started questioning if the option really existed at all or if I'd just misremembered. (using Kubuntu Linux, if it makes any difference)

toasterking commented 3 weeks ago

Me too, with WF 6.5.0 on Win10.

jabcreations commented 2 weeks ago

I have fixed this at my end and am implementing a couple of tutorials in my very limited free time. This will not count as a fix in the browser itself though a user-applied-patch (not an official term) though it will work. I'll post an update later once the tutorials are reasonably well established.

Image

jabcreations commented 2 weeks ago

There are two tutorials to do a user-patched restart browser button. You have to first enable the userChrome.js file and then you can follow the shorter tutorial on adding the restart browser button.

I've created the tutorials available at the Fixed Firefox website here: https://www.fixedfirefox.com/userchrome-js/

robbely commented 2 weeks ago

I have fixed this at my end and am implementing a couple of tutorials in my very limited free time. This will not count as a fix in the browser itself though a user-applied-patch (not an official term) though it will work. I'll post an update later once the tutorials are reasonably well established.

Image

Can you explain how you get the icons next to the file menu items? I only have blank spaces where these should be, and the new restart item doesn't even have the icon space, just the text.

Ketrel commented 2 weeks ago

It's still missing in 6.5.1 as well.

robbely commented 2 weeks ago

It's still missing in 6.5.1 as well.

It's listed in "known issues" now though:

https://www.waterfox.net/docs/releases/6.5.1/

Ketrel commented 2 weeks ago

Oddly enough thanks to https://github.com/BrowserWorks/Waterfox/issues/3610 I didn't get the releases page when the updater ran when I used the LD_LIBRARY_PATH method. I noticed the restart missing when I went to quit the browser so I could reopen it without the library path override

jabcreations commented 2 weeks ago

I have fixed this at my end and am implementing a couple of tutorials in my very limited free time. This will not count as a fix in the browser itself though a user-applied-patch (not an official term) though it will work. I'll post an update later once the tutorials are reasonably well established. Image

Can you explain how you get the icons next to the file menu items? I only have blank spaces where these should be, and the new restart item doesn't even have the icon space, just the text.

That is Waterfox, not Firefox though you're here in the Waterfox Git so... be more specific to get more a desirable response.

robbely commented 2 weeks ago

That is Waterfox, not Firefox though you're here in the Waterfox Git so... be more specific to get more a desirable response.

Yes, I'm using Waterfox. I was referring to the icons in the image to the left of the menu items (eg the envelope to the left of "Email Link" etc), I just have empty spaces where those icons would appear on mine. From other images I've seen of both Waterfox and even recent Firefox, those icons aren't there any more so I was wondering what you used to bring them back.

EDIT: Here is an image showing what I am getting in my File menu:

Image

jabcreations commented 2 weeks ago

Go to about:config and set _userChrome.icon.global_menubar_ to true (and then restart the browser).

robbely commented 2 weeks ago

Go to about:config and set _userChrome.icon.global_menubar_ to true (and then restart the browser).

I checked and it is already set to true. It looks like you need custom css to do it (eg this one https://gist.github.com/qaz69wsx/83a90423163b65a8344b2e60fc356a58 which is incomplete. Perhaps you added something to userchrome.css in the past to do this?

jabcreations commented 2 weeks ago

Are you using Waterfox 6.0 (115 ESR) or 6.5 (128 ESR)? I'm not sure about Waterfox versions after 56 and before 115.

You may have to create a new profile and then port over your tab sessions and files. You can go through my Fixed Firefox profiles page to figure that out here:

https://www.fixedfirefox.com/profiles/

Basically start a new profile and import a few files at a time. If importing something breaks the new profile then you know where the issue is in the old profile.

robbely commented 2 weeks ago

Are you using Waterfox 6.0 (115 ESR) or 6.5 (128 ESR)? I'm not sure about Waterfox versions after 56 and before 115.

You may have to create a new profile and then port over your tab sessions and files. You can go through my Fixed Firefox profiles page to figure that out here:

https://www.fixedfirefox.com/profiles/

Basically start a new profile and import a few files at a time. If importing something breaks the new profile then you know where the issue is in the old profile.

I am using 6.5 (though I remember I didn't have the icons on 6.0). I created a temporary fresh profile, but there are still no icons. It seems from some reddit posts that no icons is the norm now, the developer of the Lepton theme has posted how to bring them back (using userchrome). I am happy using the userchrome I posted earlier and I'll likely add the missing icons one at a time, but I was curious what you had used - I'm guessing you don't know what is different in your case.

jabcreations commented 2 weeks ago

Rob, I'm thinking it might be the combination of you (possibly using) Linux and some oddball setting with the internal browser's theme. I'm using Windows 10 x64 and Waterfox 6.5/128 ESR is using the "System" theme. I don't know if Lepton is a Linux or browser theme?

robbely commented 2 weeks ago

Rob, I'm thinking it might be the combination of you (possibly using) Linux and some oddball setting with the internal browser's theme. I'm using Windows 10 x64 and Waterfox 6.5/128 ESR is using the "System" theme. I don't know if Lepton is a Linux or browser theme?

I am using the same as you Windows 10 x64 and Waterfox 6.5.1. The issue seems to be a Firefox one, not a Waterfox one (Waterfox just inherits it) and appears to be intentional. Here are a few articles I found:

https://www.reddit.com/r/firefox/comments/1fez9e3/how_is_it_that_firefox_desktop_still_doesnt_use/ https://www.reddit.com/r/waterfox/comments/wt484g/how_to_removedisablehide_menu_and_menu_bar_icons/ https://news.ycombinator.com/item?id=39428411

Lepton, I believe was a previous built-in default theme for icons/appearance etc for Firefox/Waterfox etc that now has to be installed manually.

tl;dr - if you are using an unmodified/default installation (with new profile) of the latest Firefox ESR or Waterfox, then you should have missing icons too.

jabcreations commented 2 weeks ago

Are you seriously complaining about an issue while using Firefox that doesn't occur in Waterfox on the Waterfox Git? 🤨

I just created a new Waterfox profile for Waterfox 6.5 and the icons appear.

robbely commented 2 weeks ago

Are you seriously complaining about an issue while using Firefox that doesn't occur in Waterfox on the Waterfox Git? 🤨

I just created a new Waterfox profile for Waterfox 6.5 and the icons appear.

I wasn't complaining, as I said previously I'm happy with the fix someone else posted elsewhere, I was just curious if you had done something different. I'm not sure why you're getting icons when they are supposed to have disappeared, but I'm glad we've both got them working in our own ways.

jabcreations commented 2 weeks ago

Either I misread or you mistyped though it sounds like you've got them working which is great!

spykos commented 2 weeks ago

I just created a new profile in windows and the restart button is still not shown.

robbely commented 2 weeks ago

I just created a new profile in windows and the restart button is still not shown.

It hasn't been fixed yet, but it has been added to the official list of known issues. jabcreations has a fix posted above you can use for now until it is officially fixed.