search

BrowserWorks / Waterfox

The official Waterfox 💧 source code repository
https://www.waterfox.net
Other
3.83k stars 340 forks source link

Doesn't Build Against Rust 1.33 On Arch #910

Closed ilikenwf closed 3 years ago

ilikenwf commented 5 years ago

I get a number of errors about functions not supported on this architecture (x86_64 of course) using rust 1.33 under Archlinux.

I admit this could be due to my cflags, but since downgrading to 1.32 is allowing me to build, I somewhat doubt it.

grahamperrin commented 5 years ago

Not limited to Linux.

On the freebsd-gecko list, see the responses to:

FreshPorts -- lang/rust â–¶ Announcing Rust 1.33.0 | Rust Blog â–¶ detailed release notes at https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1330-2019-02-28

From https://lists.freebsd.org/pipermail/freebsd-gecko/2019-March/009203.html:

… Either remove missing_docs from #![deny(...)] lines (or lines themselves) for each one that triggers error (no need to bother with unused ones) or add MOZ_OPTIONS+=--disable-stylo to Makefile.local. …

Re: --disable-stylo I encountered problems beyond the one mentioned at https://lists.freebsd.org/pipermail/freebsd-gecko/2019-March/009209.html …

grahamperrin commented 5 years ago

FreeBSD

Made it 🎉

Waterfox 56.2.8 built with Rust 1.33.0_1 and installed on FreeBSD-CURRENT, with this: 

root@momh167-gjp4-8570p:~ # cat /usr/ports/www/waterfox/Makefile.local 
MOZ_OPTIONS+=--disable-stylo
root@momh167-gjp4-8570p:~ #

– plus manual removal of the LLVM_CONFIG=llvm-config80 line from:

/usr/ports/www/waterfox/work/Waterfox-56.2.8/.mozconfig

There's a little more to it than that, but that's the essence.

image

Linux

I made no attempt to build.

I assume that presence of the llvm-config line will not present an obstacle.

hawkeye116477 commented 5 years ago

Probably related https://bugzilla.mozilla.org/show_bug.cgi?id=1521249

ilikenwf commented 5 years ago

As an aside, setting --disable-rust-simd and --disable-stylo in the mozconfig builds it.

grahamperrin commented 5 years ago

What happens if --disable-rust-simd is not set?

hawkeye116477 commented 5 years ago

You can just comment/remove enable-rust-simd, no need to add --disable-rust-simd :smile:.

@grahamperrin Without commenting/removing --enable-rust-simd there are errors same as on https://bugzilla.mozilla.org/show_bug.cgi?id=1521249.

hawkeye116477 commented 5 years ago

@ilikenwf You can re-enable rust-simd, stylo at build time and elf-hack now.