search

BruceKnowsHow / Ebin-Shaders

Other
124 stars 38 forks source link

Somehow managed to miss this in the previous pull request, it should … #6

Closed zombye closed 8 years ago

zombye commented 8 years ago

…now work correctly.

BruceKnowsHow commented 8 years ago

That operation can be replicated by dividing by -direction.z: vec3 interval = direction * stepSize / -direction.z;

Just pushed this into the dev branch.

Any idea how to merge into a different branch? We've moved to the dev branch for now (master currently just there to keep people from complaining about no PBR).

zombye commented 8 years ago

Just noticed that I was putting a .z where I shouldn't. Guess it works on most drivers since there hasn't been an issue reported about it, but glslangValidator says it's wrong.

Also, I think using the command line might allow you to merge into a different branch, but otherwise it is simply merged to where the person making the pull request puts it.